Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1303693005: Fix crash in tracing due to identical type names of blink gc objects. (Closed)

Created:
5 years, 4 months ago by ssid
Modified:
5 years, 4 months ago
Reviewers:
haraken, hajimehoshi
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix crash in tracing due to identical type names of blink gc objects. The WTF_PRETTY_FUNCTION takes the name of the class using the typename given by the compiler. This gives the base class name for all sub-classes. To make the dump name unique the, gcInfoIndex is appended to the object name. BUG=521490 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/platform/heap/ThreadState.cpp View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ssid
This adds the index to the dump name to make it unique. I can't think ...
5 years, 4 months ago (2015-08-19 20:44:47 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-19 23:52:08 UTC) #3
hajimehoshi
lgtm, thanks!
5 years, 4 months ago (2015-08-20 01:14:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303693005/1
5 years, 4 months ago (2015-08-20 13:34:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58251)
5 years, 4 months ago (2015-08-20 18:53:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303693005/1
5 years, 4 months ago (2015-08-21 08:32:40 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 08:37:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200975

Powered by Google App Engine
This is Rietveld 408576698