Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1303673005: Add a test of getBoundingClientRect() when white-space:pre for complex scripts (Closed)

Created:
5 years, 4 months ago by kojii
Modified:
5 years, 4 months ago
Reviewers:
drott, eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a test of getBoundingClientRect() when white-space:pre for complex scripts At one point the caret was placed at an incorrect position for complex scripts. This was caused by advances and/or bounds calculation was incorrect when white-space:pre is applied to a text run of complex scripts. It was fixed in later patches. This CL adds a test for the failure to prevent it happening again. BUG=513994 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200878

Patch Set 1 #

Patch Set 2 : Fix invalid failure #

Total comments: 2

Patch Set 3 : eae review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A LayoutTests/fast/text/international/bounds-white-space-pre.html View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kojii
PTAL.
5 years, 4 months ago (2015-08-19 10:24:11 UTC) #2
eae
LGTM https://codereview.chromium.org/1303673005/diff/20001/LayoutTests/fast/text/international/bounds-white-space-pre.html File LayoutTests/fast/text/international/bounds-white-space-pre.html (right): https://codereview.chromium.org/1303673005/diff/20001/LayoutTests/fast/text/international/bounds-white-space-pre.html#newcode18 LayoutTests/fast/text/international/bounds-white-space-pre.html:18: var expectedNode = nodes[0].firstChild; Nit, var expectedNode = ...
5 years, 4 months ago (2015-08-19 15:38:10 UTC) #3
kojii
https://codereview.chromium.org/1303673005/diff/20001/LayoutTests/fast/text/international/bounds-white-space-pre.html File LayoutTests/fast/text/international/bounds-white-space-pre.html (right): https://codereview.chromium.org/1303673005/diff/20001/LayoutTests/fast/text/international/bounds-white-space-pre.html#newcode18 LayoutTests/fast/text/international/bounds-white-space-pre.html:18: var expectedNode = nodes[0].firstChild; On 2015/08/19 15:38:10, eae wrote: ...
5 years, 4 months ago (2015-08-20 05:00:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303673005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303673005/40001
5 years, 4 months ago (2015-08-20 05:00:50 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 05:40:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200878

Powered by Google App Engine
This is Rietveld 408576698