Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1303673002: Get rid of unused member function rootEditableElement() in PositionAlgorithm<Strategy> template clas (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of unused member function rootEditableElement() in PositionAlgorithm<Strategy> template class This patch gets rid of unused member function |rootEditableElement()| in |PositionAlgorithm<Strategy>| template class to simplify source code for improving code health. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200805

Patch Set 1 : 2015-08-19T14:03:30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/core/editing/Position.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303673002/1
5 years, 4 months ago (2015-08-19 05:05:42 UTC) #2
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 05:05:58 UTC) #4
yoichio
lgtm
5 years, 4 months ago (2015-08-19 06:07:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 06:49:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303673002/1
5 years, 4 months ago (2015-08-19 07:24:09 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 07:28:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200805

Powered by Google App Engine
This is Rietveld 408576698