Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303653002: Introduce LayoutObject::createPositionWithAffinity(int offset) (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce LayoutObject::createPositionWithAffinity(int offset) This patch introduces |LayoutObject::createPositionWithAffinity()| which takes |int offset| and pass |DOWNSTREAM| to two parameters version to simplify call sites like like |PositionWithAffinity| constructor which defaults to |DOWNSTREAM|, for improving code health This patch is a preparation of introducing enum class |TextAffinity| as replacement of |EAffinity| for reducing usage of |EAffinity::DOWNSTREAM|. BUG=522038 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200802

Patch Set 1 : 2015-08-19T12:20:28 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M Source/core/layout/LayoutBR.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutReplaced.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 03:51:31 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-19 04:50:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303653002/1
5 years, 4 months ago (2015-08-19 04:50:43 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 06:32:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200802

Powered by Google App Engine
This is Rietveld 408576698