Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303633002: DevTools: [timeline tree view] Rename Group-by UI strings (Closed)

Created:
5 years, 4 months ago by alph
Modified:
5 years, 4 months ago
Reviewers:
paulirish, pfeldman, caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [timeline tree view] Rename Group-by UI strings BUG=463547 R=caseq,paulirish Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200792

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M Source/devtools/front_end/timeline/TimelineTreeView.js View 1 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
alph
5 years, 4 months ago (2015-08-19 00:11:48 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/1303633002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1303633002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode94 Source/devtools/front_end/timeline/TimelineTreeView.js:94: addGroupingOption.call(this, WebInspector.UIString("No Grouping"), WebInspector.TimelineTreeView.GroupBy.None); No grouping * Domain ...
5 years, 4 months ago (2015-08-19 00:19:14 UTC) #3
alph
https://codereview.chromium.org/1303633002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1303633002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode94 Source/devtools/front_end/timeline/TimelineTreeView.js:94: addGroupingOption.call(this, WebInspector.UIString("No Grouping"), WebInspector.TimelineTreeView.GroupBy.None); On 2015/08/19 00:19:13, pfeldman wrote: ...
5 years, 4 months ago (2015-08-19 00:23:56 UTC) #4
paulirish
lgtm
5 years, 4 months ago (2015-08-19 01:28:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303633002/20001
5 years, 4 months ago (2015-08-19 02:45:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/108744)
5 years, 4 months ago (2015-08-19 03:25:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303633002/20001
5 years, 4 months ago (2015-08-19 03:35:57 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:52:20 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200792

Powered by Google App Engine
This is Rietveld 408576698