Issue 130353002: Remove the last occurence of fullPath from file_operation_manager.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130353002: Remove the last occurence of fullPath from file_operation_manager.js. (Closed)

Created:
6 years, 11 months ago by mtomasz

Modified:
6 years, 11 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the last occurence of fullPath from file_operation_manager.js. This patch removes working on fullPath from the isMovable() method. Instead the volume manager is used. TEST=Tested manually, also partly covered by browser tests. BUG=329435 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243847

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	chrome/browser/resources/file_manager/background/js/file_operation_manager.js	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/130353002/1

6 years, 11 months ago (2014-01-09 03:49:06 UTC) #3

Message was sent while issue was closed.

Change committed as 243847

Expand Messages | Collapse Messages