Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 1303423009: [sql] Drop sqlite3_* proxy hacks. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler
Modified:
5 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Drop sqlite3_* proxy hacks. Now that sqlite is a shlib under component build, the hacks to proxy functions are not necessary. BUG=489444 TBR=michaeln@chromium.org Committed: https://crrev.com/6ce9d1f07cc14b844aca059a5f7de3eb051cf37f Cr-Commit-Position: refs/heads/master@{#346994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -78 lines) Patch
M sql/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sql/connection_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
D sql/proxy.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sql/proxy.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M sql/sql.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303423009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303423009/1
5 years, 3 months ago (2015-09-02 18:06:53 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-02 19:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303423009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303423009/1
5 years, 3 months ago (2015-09-02 19:31:19 UTC) #7
Scott Hess - ex-Googler
TBR'ing based on original LGTM from: https://codereview.chromium.org/1322463002/ This piece of the code was broken off ...
5 years, 3 months ago (2015-09-02 19:31:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 19:37:52 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 19:38:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ce9d1f07cc14b844aca059a5f7de3eb051cf37f
Cr-Commit-Position: refs/heads/master@{#346994}

Powered by Google App Engine
This is Rietveld 408576698