Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1303423006: Revert of Fix CPU profiler deadlock on Windows + AMD CPU. (Closed)

Created:
5 years, 3 months ago by alph
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix CPU profiler deadlock on Windows + AMD CPU. (patchset #1 id:1 of https://codereview.chromium.org/1304873011/ ) Reason for revert: Broke a test Original issue's description: > Fix CPU profiler deadlock on Windows + AMD CPU. > > Implement a lock free version of RolloverProtectedTickClock::Now > to eliminate a deadlock. > > BUG=chromium:521420 > LOG=Y > > Committed: https://crrev.com/d6db8e5902af1f067f0f149844f4e92824ee93f3 > Cr-Commit-Position: refs/heads/master@{#30489} TBR=yurys@chromium.org,caseq@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:521420 Committed: https://crrev.com/8e78d55d6ee2fd50f14a316b767c617988acbde6 Cr-Commit-Position: refs/heads/master@{#30490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/base/platform/time.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Created Revert of Fix CPU profiler deadlock on Windows + AMD CPU.
5 years, 3 months ago (2015-09-01 04:10:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303423006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303423006/1
5 years, 3 months ago (2015-09-01 04:10:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 04:11:05 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 04:11:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e78d55d6ee2fd50f14a316b767c617988acbde6
Cr-Commit-Position: refs/heads/master@{#30490}

Powered by Google App Engine
This is Rietveld 408576698