Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 1303413005: Remove work-around for Win-Clang in-class initializer bug (Closed)

Created:
5 years, 4 months ago by hans
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove work-around for Win-Clang in-class initializer bug BUG=488634 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/core/css/resolver/MatchResult.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/MatchResult.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
hans
Please take a look.
5 years, 4 months ago (2015-08-25 18:01:33 UTC) #2
Nico
lgtm
5 years, 4 months ago (2015-08-25 18:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303413005/1
5 years, 4 months ago (2015-08-25 18:05:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104037)
5 years, 4 months ago (2015-08-25 19:00:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303413005/1
5 years, 4 months ago (2015-08-25 19:32:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/103333)
5 years, 4 months ago (2015-08-25 21:26:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303413005/1
5 years, 4 months ago (2015-08-25 21:29:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/103407)
5 years, 4 months ago (2015-08-25 22:40:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303413005/1
5 years, 4 months ago (2015-08-25 22:43:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303413005/1
5 years, 4 months ago (2015-08-25 22:46:11 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 22:49:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201164

Powered by Google App Engine
This is Rietveld 408576698