Source/core/layout/line/RootInlineBox.cpp - Issue 1303413004: Convert some call sites to use explicit LayoutRect->FloatRect conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/RootInlineBox.cpp

Issue 1303413004: Convert some call sites to use explicit LayoutRect->FloatRect conversion. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/line/RootInlineBox.cpp

diff --git a/Source/core/layout/line/RootInlineBox.cpp b/Source/core/layout/line/RootInlineBox.cpp

index aae81d3d5aa19b73eeada1bb29d5572c81f4244c..b4c3c2158c027f61bc6aa188e2413e03a27a0482 100644

--- a/Source/core/layout/line/RootInlineBox.cpp

+++ b/Source/core/layout/line/RootInlineBox.cpp

@@ -318,7 +318,7 @@ GapRects RootInlineBox::lineSelectionGap(const LayoutBlock* rootBlock, const Lay

LayoutRect gapRect = rootBlock->logicalRectToPhysicalRect(rootBlockPhysicalPosition, logicalRect);

if (isPreviousBoxSelected && gapRect.width() > 0 && gapRect.height() > 0) {

if (paintInfo && box->parent()->lineLayoutItem().style()->visibility() == VISIBLE)

- paintInfo->context->fillRect(gapRect, box->parent()->lineLayoutItem().selectionBackgroundColor());

+ paintInfo->context->fillRect(FloatRect(gapRect), box->parent()->lineLayoutItem().selectionBackgroundColor());

// VisibleSelection may be non-contiguous, see comment above.

result.uniteCenter(gapRect);

}