Source/core/frame/RootFrameViewport.cpp - Issue 1303413004: Convert some call sites to use explicit LayoutRect->FloatRect conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RootFrameViewport.cpp

Issue 1303413004: Convert some call sites to use explicit LayoutRect->FloatRect conversion. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/RootFrameViewport.cpp

diff --git a/Source/core/frame/RootFrameViewport.cpp b/Source/core/frame/RootFrameViewport.cpp

index 6ba7d2e5d353e405d89374dfaf3594284ac09da3..84601b5bfbee029561c3c1fa00f8e8857ad0e6e2 100644

--- a/Source/core/frame/RootFrameViewport.cpp

+++ b/Source/core/frame/RootFrameViewport.cpp

@@ -161,8 +161,7 @@ LayoutRect RootFrameViewport::scrollIntoView(const LayoutRect& rectInContent, co

targetViewport.setSize(LayoutSize(visualViewport().visibleContentRect().size()));

// Snap the visible rect to layout units to match the calculated target viewport rect.

- FloatRect visible =

- LayoutRect(visualViewport().scrollPositionDouble(), visualViewport().visibleContentRect().size());

+ FloatRect visible(LayoutRect(visualViewport().scrollPositionDouble(), visualViewport().visibleContentRect().size()));

float centeringOffsetX = (visible.width() - targetViewport.width()) / 2;

float centeringOffsetY = (visible.height() - targetViewport.height()) / 2;