Source/core/editing/Editor.cpp - Issue 1303413004: Convert some call sites to use explicit LayoutRect->FloatRect conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Editor.cpp

Issue 1303413004: Convert some call sites to use explicit LayoutRect->FloatRect conversion. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/Caret.cpp ('k') | Source/core/editing/markers/DocumentMarkerControllerTest.cpp » ('j') | Source/core/editing/markers/DocumentMarkerControllerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/Editor.cpp

diff --git a/Source/core/editing/Editor.cpp b/Source/core/editing/Editor.cpp

index 2414b6525e8db3143cbade4554f5c20f031421a3..41c48c5c1f82c348a6982729c357d9ebf2e45db7 100644

--- a/Source/core/editing/Editor.cpp

+++ b/Source/core/editing/Editor.cpp

@@ -1086,11 +1086,11 @@ IntRect Editor::firstRectForRange(const EphemeralRange& range) const

ASSERT(range.isNotNull());

IntRect startCaretRect = RenderedPosition(VisiblePosition(range.startPosition()).deepEquivalent(), TextAffinity::Downstream).absoluteRect(&extraWidthToEndOfLine);

- if (startCaretRect == LayoutRect())

+ if (startCaretRect.isEmpty())

return IntRect();

IntRect endCaretRect = RenderedPosition(VisiblePosition(range.endPosition()).deepEquivalent(), TextAffinity::Upstream).absoluteRect();

- if (endCaretRect == LayoutRect())

+ if (endCaretRect.isEmpty())

return IntRect();

if (startCaretRect.y() == endCaretRect.y()) {