Convert some call sites to use explicit LayoutRect->FloatRect conversion.

Source/core/editing/markers/DocumentMarkerControllerTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 183 matching lines @@
         EXPECT_EQ(1u, markerController().markers().size());
         setBodyInnerHTML("");
     }
     // No more reference to marked node.
     Heap::collectAllGarbage();
     EXPECT_EQ(0u, markerController().markers().size());
 }
 
 TEST_F(DocumentMarkerControllerTest, UpdateRenderedRects)
 {
-    LayoutRect invalidRect = RenderedDocumentMarker::create(DocumentMarker(0, 0, false))->renderedRect();
+    IntRect invalidRect(RenderedDocumentMarker::create(DocumentMarker(0, 0, false))->renderedRect());

[eae, 2015/08/25 17:47:16]

renderRect() returns a LayoutRect, this implicitly down converts that to an
IntRect which doesn't seem right. 

Explicitly calling pixelSnappedIntRect or enclosingIntRect would be better.

[chrishtr, 2015/08/25 18:30:43]

It's implicit in the same way that renderedRectsForMarkers is implicit, because
it builds a vector of IntRects that are constructed by calling
results.append() with a LayoutRect:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Should there be a followup task to remove the IntRect constructor that takes in
a LayoutRect?

 
     setBodyInnerHTML("<div style='margin: 100px'>foo</div>");
     RefPtrWillBeRawPtr<Element> div = toElement(document().body()->firstChild());
     markNodeContents(div);
     Vector<IntRect> renderedRects = markerController().renderedRectsForMarkers(DocumentMarker::Spelling);
     EXPECT_EQ(1u, renderedRects.size());
     EXPECT_NE(invalidRect, renderedRects[0]);
 
     div->setAttribute(HTMLNames::styleAttr, "margin: 200px");
     document().updateLayout();
     Vector<IntRect> newRenderedRects = markerController().renderedRectsForMarkers(DocumentMarker::Spelling);
     EXPECT_EQ(1u, newRenderedRects.size());
     EXPECT_NE(renderedRects[0], newRenderedRects[0]);
 }
 
 } // namespace blink