Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issue 1303403007: bindings: Enables attribute tests for Location. (Closed)

Created:
5 years, 3 months ago by Yuki
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Enables attribute tests for Location. This CL just enables the test, not fixes any issue. We'll fix the issues step by step. Since some of Location's attributes are cross-origin accessible, we can't fix all the issues right away. BUG=491006 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201470

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-access-over-property-descriptor-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL?
5 years, 3 months ago (2015-08-31 06:37:01 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-08-31 06:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403007/20001
5 years, 3 months ago (2015-08-31 06:44:42 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 07:17:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201470

Powered by Google App Engine
This is Rietveld 408576698