Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1303393004: Revert of [heap] More flag cleanup. (Closed)

Created:
5 years, 3 months ago by Michael Hablich
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] More flag cleanup. (patchset #8 id:140001 of https://codereview.chromium.org/1314863003/ ) Reason for revert: Breaks http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20-%202/builds/2372 Original issue's description: > [heap] GC flag cleanup/restructuring. > > * GC's flags are now proper flags and not int. > * Callback flags are not threaded through but only set once like gc flags > * Callers of methods that trigger GCs need to pass a reason when not using > the default parameters. > > Furthermore, each GC invocation can be passed the GC and GCCallback flags. We > usually override the currently set flags upon finishing a GC cylce, but are able > to restore the previously set if desired. This is useful for explicitely > triggered scavenges or external requests that interrupt the current behaviour. > > BUG= > > Committed: https://crrev.com/f4f3b431b9ce0778d926acf03c0d36dae5c0cba4 > Cr-Commit-Position: refs/heads/master@{#30457} TBR=hpayer@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6eb837697a2f92c96d9e48c162f7b0391eb16556 Cr-Commit-Position: refs/heads/master@{#30463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -252 lines) Patch
M src/api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/heap/heap.h View 9 chunks +27 lines, -69 lines 0 comments Download
M src/heap/heap.cc View 16 chunks +32 lines, -31 lines 0 comments Download
M src/heap/heap-inl.h View 3 chunks +30 lines, -41 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/log.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 22 chunks +33 lines, -37 lines 0 comments Download
M test/cctest/test-debug.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 21 chunks +32 lines, -33 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-mementos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-weaksets.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Hablich
Created Revert of [heap] More flag cleanup.
5 years, 3 months ago (2015-08-31 10:23:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303393004/1
5 years, 3 months ago (2015-08-31 10:23:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 10:23:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6eb837697a2f92c96d9e48c162f7b0391eb16556 Cr-Commit-Position: refs/heads/master@{#30463}
5 years, 3 months ago (2015-08-31 10:23:41 UTC) #4
Michael Achenbach
5 years, 3 months ago (2015-08-31 11:01:29 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698