MD Downloads: remove per-item scrollbarWidth handling

MD Downloads: remove per-item scrollbarWidth handling

R=esprehn@chromium.org
BUG=526581
NOTRY=true

Committed: https://crrev.com/507d2fc1b0c0552e5a7486b7fda3c16c78d19383
Cr-Commit-Position: refs/heads/master@{#348531}

[Dan Beam, 2015-09-09 02:17:20]

so what do you think about this overall?  do you want me to detect overlay
scrolling so that the hardcoded 15px is always right?

if you do: I'd probably make an offscreen div that's guaranteed to have a
scrollbar and check the difference between clientWidth and offsetWidth once and
write a dynamic stylesheet (which would also need to be CSS variable
polyfilled).

[Dan Beam, 2015-09-11 01:36:53]

ping esprehn@

[esprehn, 2015-09-11 19:00:17]

On 2015/09/09 at 02:17:20, dbeam wrote:
> so what do you think about this overall?  do you want me to detect overlay
scrolling so that the hardcoded 15px is always right?
> 
> if you do: I'd probably make an offscreen div that's guaranteed to have a
scrollbar and check the difference between clientWidth and offsetWidth once and
write a dynamic stylesheet (which would also need to be CSS variable
polyfilled).

No need for a dynamic stylesheet, just early return from the function and never
add the .has-scrollbar class in that case. I do think you want to detect this,
otherwise on OS X with overlay scrollbars you're making things not line up.

[esprehn, 2015-09-11 22:51:06]

On 2015/09/11 at 19:00:17, esprehn wrote:
> On 2015/09/09 at 02:17:20, dbeam wrote:
> > so what do you think about this overall?  do you want me to detect overlay
scrolling so that the hardcoded 15px is always right?
> > 
> > if you do: I'd probably make an offscreen div that's guaranteed to have a
scrollbar and check the difference between clientWidth and offsetWidth once and
write a dynamic stylesheet (which would also need to be CSS variable
polyfilled).
> 
> No need for a dynamic stylesheet, just early return from the function and
never add the .has-scrollbar class in that case. I do think you want to detect
this, otherwise on OS X with overlay scrollbars you're making things not line
up.

Hmm now that I think about this, scrollbars can go between overlay and not
overlay dynamically as well if the user changes the system settings. I'm not
sure how you detect that in the page though, there's no easy way.

[Dan Beam, 2015-09-11 23:22:00]

just using overflow-y: overlay; now.  booyah!

[esprehn, 2015-09-11 23:24:34]

Lgtm, amazing!

[Dan Beam, 2015-09-11 23:35:56]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-09-11 23:36:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303363004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303363004/20001

[commit-bot: I haz the power, 2015-09-12 00:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 00:24:04]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2015-09-12 00:58:32]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-09-12 00:59:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303363004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303363004/20001

[commit-bot: I haz the power, 2015-09-12 02:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 02:23:33]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2015-09-12 19:23:08]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-09-12 19:23:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303363004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303363004/20001

[commit-bot: I haz the power, 2015-09-12 19:28:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-12 19:29:42]

Patchset 2 (id:??) landed as
https://crrev.com/507d2fc1b0c0552e5a7486b7fda3c16c78d19383
Cr-Commit-Position: refs/heads/master@{#348531}

[commit-bot: I haz the power, 2015-09-23 12:28:06]

Patchset 2 (id:??) landed as
https://crrev.com/507d2fc1b0c0552e5a7486b7fda3c16c78d19383
Cr-Commit-Position: refs/heads/master@{#348531}