Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1303333006: Don't crash for subframes after in-page navigations in --site-per-process. (Closed)

Created:
5 years, 4 months ago by Charlie Reis
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't crash for subframes after in-page navigations in --site-per-process. This is a stopgap until we can clone the subframe FNEs from the last committed entry on in-page navigations. See bug comment 5 for details. BUG=522193 TEST=See bug comment 4 for repro steps. Committed: https://crrev.com/e062d54a2a6f42af08653ac5ae201028b7be0ac1 Cr-Commit-Position: refs/heads/master@{#345238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -6 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Avi, can you take a look? My larger plans for cloning the FNEs are described ...
5 years, 4 months ago (2015-08-24 21:11:49 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 4 months ago (2015-08-25 00:42:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303333006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303333006/1
5 years, 4 months ago (2015-08-25 01:57:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 02:02:15 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 02:03:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e062d54a2a6f42af08653ac5ae201028b7be0ac1
Cr-Commit-Position: refs/heads/master@{#345238}

Powered by Google App Engine
This is Rietveld 408576698