Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1303323005: Upgrade dart sdk to 1.13.0-dev.0.0 (Closed)

Created:
5 years, 3 months ago by tonyg
Modified:
5 years, 3 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Upgrade dart sdk to 1.13.0-dev.0.0 My motivation is to be able to use the latest version of the yaml packages which requires 1.12.0 at minimum (which our previous pre-release version didn't match). BUG= R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/23cfa759a0c34c706d2e19220d99defa502f5e8d

Patch Set 1 #

Total comments: 1

Patch Set 2 : 1.13.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/dart/update.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tonyg
5 years, 3 months ago (2015-09-03 14:30:41 UTC) #2
zra
https://codereview.chromium.org/1303323005/diff/1/tools/dart/update.py File tools/dart/update.py (right): https://codereview.chromium.org/1303323005/diff/1/tools/dart/update.py#newcode20 tools/dart/update.py:20: SDK_URL_BASE = ('http://gsdview.appspot.com/dart-archive/channels/stable/raw/' It looks like sky is on ...
5 years, 3 months ago (2015-09-03 14:45:29 UTC) #3
tonyg
done -- ptal
5 years, 3 months ago (2015-09-03 14:49:31 UTC) #4
zra
lgtm
5 years, 3 months ago (2015-09-03 14:54:14 UTC) #5
tonyg
5 years, 3 months ago (2015-09-03 14:55:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
23cfa759a0c34c706d2e19220d99defa502f5e8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698