Issue 1303323003: Ignore in-page navigations on the initial blank page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1303323003: Ignore in-page navigations on the initial blank page. (Closed)

Created:
5 years, 4 months ago by Charlie Reis

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ignore in-page navigations on the initial blank page. The initial blank page has no committed NavigationEntry, and in-page navigations preserve the frame tree. To be consistent, we should not have NavigationEntries for in-page navigations on that page either. BUG=522193 TEST=Add subframe to initial about:blank, then in-page navigation, then add grandchild subframe. Shouldn't crash in --site-per-process. [Closed: Decided to create NavEntries for the initial blank page instead.]

Patch Set 1 #

Patch Set 2 : Clean up and add test #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -4 lines)			Patch
	M	content/browser/frame_host/navigation_controller_impl.cc	View	1	2 chunks	+13 lines, -4 lines	0 comments	Download
	M	content/browser/frame_host/navigation_controller_impl_browsertest.cc	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download