Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1303313007: Temporary fix to the inconsistency in skia dump. (Closed)

Created:
5 years, 3 months ago by ssid
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@skia_res
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporary fix to the inconsistency in skia dump. This CL just removes the light dump check and creates a detailed dump every call. This might be heavy, but still feasible. Added a TODO to fix this till I figure out a plan to make light dumps for skia. TBR=reed@google.com BUG=528295 Committed: https://crrev.com/734cd09011f712b5025880d05c9f3b9916cb29a8 Cr-Commit-Position: refs/heads/master@{#347556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M skia/ext/skia_memory_dump_provider.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
ssid
Small fix PTAL, thanks.
5 years, 3 months ago (2015-09-04 15:19:13 UTC) #2
Primiano Tucci (use gerrit)
lgtm
5 years, 3 months ago (2015-09-04 17:56:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303313007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303313007/1
5 years, 3 months ago (2015-09-04 17:57:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/49448)
5 years, 3 months ago (2015-09-04 19:43:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303313007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303313007/1
5 years, 3 months ago (2015-09-05 04:00:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-05 04:43:22 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 04:44:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/734cd09011f712b5025880d05c9f3b9916cb29a8
Cr-Commit-Position: refs/heads/master@{#347556}

Powered by Google App Engine
This is Rietveld 408576698