Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1303313006: Fix flakiness of imported/web-platform-tests/html/syntax/parsing/html5lib_testsNN.html. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix flakiness of imported/web-platform-tests/html/syntax/parsing/html5lib_testsNN.html. Root cause: Our testharnessreport.js removes unnecessary text nodes in a callback registered by add_completion_callback() [1]. The html5lib tests add other completion callbacks to show failure reasons, and they run after the callback of testharnessreport.js. So, the failure reasons remain in *-expected.txt. Resolution: testharness.js doesn't provide a way to specify that "This callback must run at the end of callbacks." So we delay the text nodes cleanup by setTimeout(done, 0). [1] https://github.com/w3c/testharness.js/blob/master/docs/api.md#callback-api BUG=527262 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -282 lines) Patch
M LayoutTests/SlowTests View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/resources/testharnessreport.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/w3c/resources/testharnessreport.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/syntax/parsing/html5lib_tests11-expected.txt View 1 chunk +0 lines, -276 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/resources/testharnessreport.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/resources/testharnessreport.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
kojii@, can you review this?
5 years, 3 months ago (2015-09-02 06:46:54 UTC) #2
kojii
lgtm
5 years, 3 months ago (2015-09-02 07:46:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303313006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303313006/1
5 years, 3 months ago (2015-09-02 07:47:38 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 08:04:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201628

Powered by Google App Engine
This is Rietveld 408576698