Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1303303005: Makes all tests isolated for now (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes all tests isolated for now There are race conditions to do otherwise. Until they are sorted out, we should run isolated, otherwise we're going to have flake. BUG=529487 TEST=none R=msw@chromium.org Committed: https://crrev.com/86877aa2c58114f70eb5fcf4db5b0adc33ea92d7 Cr-Commit-Position: refs/heads/master@{#348222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mojo/tools/apptest_runner.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
sky
5 years, 3 months ago (2015-09-08 22:53:31 UTC) #1
msw
lgtm
5 years, 3 months ago (2015-09-08 23:44:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303303005/1
5 years, 3 months ago (2015-09-08 23:45:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/131861)
5 years, 3 months ago (2015-09-09 00:49:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303303005/1
5 years, 3 months ago (2015-09-09 15:00:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/132105)
5 years, 3 months ago (2015-09-09 15:47:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303303005/1
5 years, 3 months ago (2015-09-10 18:26:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105464)
5 years, 3 months ago (2015-09-10 19:28:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303303005/1
5 years, 3 months ago (2015-09-10 19:44:28 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 20:19:38 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86877aa2c58114f70eb5fcf4db5b0adc33ea92d7 Cr-Commit-Position: refs/heads/master@{#348222}
5 years, 3 months ago (2015-09-10 20:20:32 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:13:37 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86877aa2c58114f70eb5fcf4db5b0adc33ea92d7
Cr-Commit-Position: refs/heads/master@{#348222}

Powered by Google App Engine
This is Rietveld 408576698