Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1303303002: [Line Layout API] Convert most of InlineBoxPainter to new API (Closed)

Created:
5 years, 4 months ago by pilgrim_google
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Line Layout API] Convert most of InlineBoxPainter to new API This CL adds two necessary methods to the line layout API and updates callers to use them. 1. LineLayoutBoxModel::boxShadowShouldBeAppliedToBackground 2. LineLayoutItem::enclosingBoxModelObject (implemented in LineLayoutBoxModel.h to avoid pulling LayoutBoxModel into LineLayoutItem) BUG=499321 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201013

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M Source/core/layout/api/LineLayoutBoxModel.h View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/layout/api/LineLayoutItem.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pilgrim_google
5 years, 4 months ago (2015-08-21 14:46:47 UTC) #2
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1303303002/diff/1/Source/core/layout/api/LineLayoutItem.h File Source/core/layout/api/LineLayoutItem.h (right): https://codereview.chromium.org/1303303002/diff/1/Source/core/layout/api/LineLayoutItem.h#newcode70 Source/core/layout/api/LineLayoutItem.h:70: // Intentionally returns a BoxModel to avoid exposing ...
5 years, 4 months ago (2015-08-21 18:37:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303303002/20001
5 years, 4 months ago (2015-08-21 19:08:31 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 21:10:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201013

Powered by Google App Engine
This is Rietveld 408576698