Concurrently unmap free pages.

Concurrently unmap free pages.

BUG=

Committed: https://crrev.com/d1aeb45d96123d47023066b244c0f450fbe57d2d
Cr-Commit-Position: refs/heads/master@{#30306}

[Hannes Payer (out of office), 2015-08-21 12:15:00]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Michael Lippautz, 2015-08-21 12:28:59]

lgtm

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:6664: 
-line

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.h#newcode...
src/heap/heap.h:1686: class UnmapFreeMemoryTask;
Move to the top of the private section.

https://codereview.chromium.org/1303263002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:529: heap()->WaitUntilUnmappingOfFreeChunksCompleted();
Just a note: This is dependent on "sweeping_in_progress()". Maybe we can think
of a way to make this less fragile.

[Hannes Payer (out of office), 2015-08-21 12:45:07]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-21 12:45:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1303263002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-21 12:45:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303263002/40001

[commit-bot: I haz the power, 2015-08-21 12:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 12:45:56]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5115)

[Hannes Payer (out of office), 2015-08-21 12:56:04]

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:6664: 
On 2015/08/21 12:28:58, Michael Lippautz wrote:
> -line

Done.

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.h#newcode...
src/heap/heap.h:1686: class UnmapFreeMemoryTask;
On 2015/08/21 12:28:58, Michael Lippautz wrote:
> Move to the top of the private section.

Done.

https://codereview.chromium.org/1303263002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:529: heap()->WaitUntilUnmappingOfFreeChunksCompleted();
On 2015/08/21 12:28:58, Michael Lippautz wrote:
> Just a note: This is dependent on "sweeping_in_progress()". Maybe we can think
> of a way to make this less fragile.

Acknowledged.

[Hannes Payer (out of office), 2015-08-21 12:56:08]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-21 12:56:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1303263002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-08-21 12:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303263002/60001

[commit-bot: I haz the power, 2015-08-21 13:25:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-21 13:25:18]

Patchset 4 (id:??) landed as
https://crrev.com/d1aeb45d96123d47023066b244c0f450fbe57d2d
Cr-Commit-Position: refs/heads/master@{#30306}

[vogelheim, 2015-08-21 16:20:35]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1306213002/ by vogelheim@chromium.org.

The reason for reverting is: Several tests on V8 Linux64 TSAN bot are broken,
due to data races between allocation & GC.

A bisect points to this CL, and the CL description sounds pertinent to the
observed breakage.
.