Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303233007: Blink Plugins: Remove Shadow DOM plugin placeholder tests. (Closed)

Created:
5 years, 3 months ago by tommycli
Modified:
5 years, 3 months ago
Reviewers:
pdr., jbroman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Blink Plugins: Remove Shadow DOM plugin placeholder tests. This is a subset of https://codereview.chromium.org/1313763002/. The tests have to be removed in a separate patch to unblock the Chromium-side patch: https://codereview.chromium.org/1314643002/. BUG=524115 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -544 lines) Patch
M LayoutTests/fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash.html View 1 chunk +1 line, -7 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder.css View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-close.html View 1 chunk +0 lines, -104 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-close-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-csp.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-csp-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-explicit-size.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-explicit-size-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-focus.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-focus-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-inherit.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-inherit-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-not-exposed.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-not-exposed-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-structured.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-structured-expected.html View 1 chunk +0 lines, -24 lines 0 comments Download
D Source/web/PluginPlaceholderImplTest.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 3 chunks +0 lines, -33 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1313763002 Patch 100001

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303233007/1
5 years, 3 months ago (2015-08-26 20:22:27 UTC) #2
tommycli
pdr/jbroman: PTAL. This is a subset of the other patch. The tests need to be ...
5 years, 3 months ago (2015-08-26 20:26:48 UTC) #4
tommycli
On 2015/08/26 20:26:48, tommycli wrote: > pdr/jbroman: PTAL. > > This is a subset of ...
5 years, 3 months ago (2015-08-26 20:27:19 UTC) #5
pdr.
lgtm
5 years, 3 months ago (2015-08-26 20:33:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303233007/1
5 years, 3 months ago (2015-08-26 21:03:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93251)
5 years, 3 months ago (2015-08-26 21:14:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303233007/1
5 years, 3 months ago (2015-08-26 21:21:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93268)
5 years, 3 months ago (2015-08-26 21:32:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303233007/1
5 years, 3 months ago (2015-08-26 21:44:32 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93286)
5 years, 3 months ago (2015-08-26 21:54:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303233007/1
5 years, 3 months ago (2015-08-26 23:29:20 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 00:45:39 UTC) #22
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201270

Powered by Google App Engine
This is Rietveld 408576698