build/android/lint/suppressions.xml - Issue 1303213004: New illustrations for the Data Reduction Proxy promo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/lint/suppressions.xml

Issue 1303213004: New illustrations for the Data Reduction Proxy promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: image size and buttons fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/drawable-mdpi/data_reduction_illustration.png » ('j') | chrome/android/java/res/layout/data_reduction_promo_screen.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <lint>	2 <lint>

3 <!--	3 <!--

4 STOP! It looks like you want to suppress some lint errors:	4 STOP! It looks like you want to suppress some lint errors:

5 - Have you tried identifing the offending patch?	5 - Have you tried identifing the offending patch?

6 Ask the author for a fix and/or revert the patch.	6 Ask the author for a fix and/or revert the patch.

7 - It is preferred to add suppressions in the code instead of	7 - It is preferred to add suppressions in the code instead of

8 sweeping it under the rug here. See:	8 sweeping it under the rug here. See:

9	9

10 http://developer.android.com/tools/debugging/improving-w-lint.html	10 http://developer.android.com/tools/debugging/improving-w-lint.html

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
98 <ignore path="chrome/android/java/res/xml/bookmark_thumbnail_widget_info.xml " />	98 <ignore path="chrome/android/java/res/xml/bookmark_thumbnail_widget_info.xml " />

99 <ignore path="chrome/android/java/res/xml/file_paths.xml" />	99 <ignore path="chrome/android/java/res/xml/file_paths.xml" />

100	100

101 <ignore path="content/shell/android/shell_apk/res/layout/content_shell_activ ity.xml" />	101 <ignore path="content/shell/android/shell_apk/res/layout/content_shell_activ ity.xml" />

102 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />	102 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />

103 </issue>	103 </issue>

104 <issue id="SignatureOrSystemPermissions" severity="ignore"/>	104 <issue id="SignatureOrSystemPermissions" severity="ignore"/>

105 <issue id="UnusedAttribute" severity="ignore"/>	105 <issue id="UnusedAttribute" severity="ignore"/>

106 <issue id="ViewConstructor" severity="ignore"/>	106 <issue id="ViewConstructor" severity="ignore"/>

107 <issue id="WrongCall" severity="ignore"/>	107 <issue id="WrongCall" severity="ignore"/>

	108 <issue id="UselessParent">

	109 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " />

	110 </issue>

108 </lint>	111 </lint>

OLD	NEW