Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303213002: Returning const ref instead of const value in DictionaryPreferenceIterator::url (Closed)

Created:
5 years, 4 months ago by Paritosh Kumar
Modified:
5 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning const ref instead of const value in DictionaryPreferenceIterator::url BUG=393155 Committed: https://crrev.com/fa4c7240482361a6780d0850c01e3effa082ac9a Cr-Commit-Position: refs/heads/master@{#345019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/sdch/sdch_owner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paritosh Kumar
Please have a look.
5 years, 4 months ago (2015-08-21 12:56:29 UTC) #2
mmenke
On 2015/08/21 12:56:29, Paritosh Kumar wrote: > Please have a look. LGTM, thanks for catching ...
5 years, 4 months ago (2015-08-21 16:09:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303213002/1
5 years, 4 months ago (2015-08-24 01:51:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 02:45:12 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 02:46:22 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fa4c7240482361a6780d0850c01e3effa082ac9a
Cr-Commit-Position: refs/heads/master@{#345019}

Powered by Google App Engine
This is Rietveld 408576698