Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1303203004: Revert of Add fallback fonts for math and symbol blocks on Windows (Closed)

Created:
5 years, 3 months ago by Jeffrey Yasskin
Modified:
5 years, 3 months ago
Reviewers:
ebraminio, szager, szager1, eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add fallback fonts for math and symbol blocks on Windows (patchset #4 id:60001 of https://codereview.chromium.org/1314543011/ ) Reason for revert: This appears to have broken DrMemory. I believe this isn't your fault; you just exposed the bug that https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp&l=399-408 fails to set *scriptChecked. But I still want to get DrMemory green again. http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/5881 ### BEGIN MEMORY TOOL REPORT (error hash=#D08ACED1904C5DA6#) UNINITIALIZED READ: reading 0x1022d6a0-0x1022d6a4 4 byte(s) # 0 blink_platform.dll!blink::FontCache::fallbackFontForCharacter [third_party\webkit\source\platform\fonts\win\fontcacheskiawin.cpp:188] # 1 blink_platform.dll!blink::Font::glyphDataForCharacter [third_party\webkit\source\platform\fonts\font.cpp:521] # 2 blink_platform.dll!blink::SimpleShaper::glyphDataForCharacter [third_party\webkit\source\platform\fonts\shaping\simpleshaper.cpp:67] # 3 blink_platform.dll!blink::SimpleShaper::advanceInternal<> [third_party\webkit\source\platform\fonts\shaping\simpleshaper.cpp:141] # 4 blink_platform.dll!blink::SimpleShaper::advance [third_party\webkit\source\platform\fonts\shaping\simpleshaper.cpp:214] # 5 blink_platform.dll!blink::Font::floatWidthForSimpleText [third_party\webkit\source\platform\fonts\font.cpp:750] # 6 blink_platform.dll!blink::Font::width [third_party\webkit\source\platform\fonts\font.cpp:234] # 7 webcore_shared.dll!blink::BreakingContext::handleText [third_party\webkit\source\core\layout\line\breakingcontextinlineheaders.h:652] # 8 webcore_shared.dll!blink::LineBreaker::nextLineBreak [third_party\webkit\source\core\layout\line\linebreaker.cpp:88] # 9 webcore_shared.dll!blink::LayoutBlockFlow::layoutRunsAndFloatsInRange [third_party\webkit\source\core\layout\layoutblockflowline.cpp:807] #10 webcore_shared.dll!blink::LayoutBlockFlow::layoutRunsAndFloats [third_party\webkit\source\core\layout\layoutblockflowline.cpp:756] #11 webcore_shared.dll!blink::LayoutBlockFlow::layoutInlineChildren [third_party\webkit\source\core\layout\layoutblockflowline.cpp:1580] #12 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockFlow [third_party\webkit\source\core\layout\layoutblockflow.cpp:376] #13 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlock [third_party\webkit\source\core\layout\layoutblockflow.cpp:298] #14 webcore_shared.dll!blink::LayoutBlock::layout [third_party\webkit\source\core\layout\layoutblock.cpp:907] #15 webcore_shared.dll!blink::LayoutBlockFlow::positionAndLayoutOnceIfNeeded [third_party\webkit\source\core\layout\layoutblockflow.cpp:562] #16 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChild [third_party\webkit\source\core\layout\layoutblockflow.cpp:587] #17 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChildren [third_party\webkit\source\core\layout\layoutblockflow.cpp:1042] #18 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockFlow [third_party\webkit\source\core\layout\layoutblockflow.cpp:378] #19 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlock [third_party\webkit\source\core\layout\layoutblockflow.cpp:298] #20 webcore_shared.dll!blink::LayoutBlock::layout [third_party\webkit\source\core\layout\layoutblock.cpp:907] #21 webcore_shared.dll!blink::LayoutBlockFlow::positionAndLayoutOnceIfNeeded [third_party\webkit\source\core\layout\layoutblockflow.cpp:562] #22 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChild [third_party\webkit\source\core\layout\layoutblockflow.cpp:587] #23 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChildren [third_party\webkit\source\core\layout\layoutblockflow.cpp:1042] #24 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockFlow [third_party\webkit\source\core\layout\layoutblockflow.cpp:378] #25 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlock [third_party\webkit\source\core\layout\layoutblockflow.cpp:298] #26 webcore_shared.dll!blink::LayoutBlock::layout [third_party\webkit\source\core\layout\layoutblock.cpp:907] #27 webcore_shared.dll!blink::LayoutView::layout [third_party\webkit\source\core\layout\layoutview.cpp:245] #28 webcore_shared.dll!blink::FrameView::performLayout [third_party\webkit\source\core\frame\frameview.cpp:865] #29 webcore_shared.dll!blink::FrameView::layout [third_party\webkit\source\core\frame\frameview.cpp:1027] #30 webcore_shared.dll!blink::Document::implicitClose [third_party\webkit\source\core\dom\document.cpp:2599] #31 webcore_shared.dll!blink::HTMLDocumentParser::end [third_party\webkit\source\core\html\parser\htmldocumentparser.cpp:867] #32 webcore_shared.dll!blink::HTMLDocumentParser::pumpPendingSpeculations [third_party\webkit\source\core\html\parser\htmldocumentparser.cpp:570] #33 webcore_shared.dll!blink::HTMLDocumentParser::resumeParsingAfterYield [third_party\webkit\source\core\html\parser\htmldocumentparser.cpp:314] #34 scheduler.dll!scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [components\scheduler\child\task_queue_manager.cc:346] #35 scheduler.dll!scheduler::TaskQueueManager::DoWork [components\scheduler\child\task_queue_manager.cc:284] #36 scheduler.dll!base::internal::Invoker<>::Run [base\bind_internal.h:346] #37 base.dll!base::debug::TaskAnnotator::RunTask [base\debug\task_annotator.cc:51] #38 base.dll!base::MessageLoop::RunTask [base\message_loop\message_loop.cc:481] #39 base.dll!base::MessageLoop::DeferOrRunPendingTask [base\message_loop\message_loop.cc:490] Note: @0:01:06.308 in thread 3248 Note: instruction: cmp 0xfffffff4(%ebp) $0x00000011 The report came from the `DomSerializerTests.SerializeHTMLDOMWithNonStandardEntities` test. Original issue's description: > Add fallback fonts for math and symbol blocks on Windows > > Add fallback fonts for more math and symbol unicode blocks on Windows to > allow better font fallback and handling of symbols that generally aren't > available in the commonly used fonts. > > R=szager@chromium.org > BUG=237023, 237050, 526354 > TEST=fast/text/unicode-fallback-font.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201930 TBR=ebraminio@gmail.com,szager@google.com,szager@chromium.org,eae@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=237023, 237050, 526354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -63 lines) Patch
M LayoutTests/TestExpectations View 6 chunks +11 lines, -39 lines 0 comments Download
M Source/platform/fonts/win/FontFallbackWin.cpp View 2 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jeffrey Yasskin
Created Revert of Add fallback fonts for math and symbol blocks on Windows
5 years, 3 months ago (2015-09-09 11:39:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303203004/1
5 years, 3 months ago (2015-09-09 11:39:42 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 11:40:06 UTC) #4
Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1135.
  Hunk #2 succeeded at 1282 (offset -34 lines).
  Hunk #3 succeeded at 1361 (offset -35 lines).
  Hunk #4 succeeded at 1413 (offset -40 lines).
  Hunk #5 succeeded at 1425 (offset -40 lines).
  Hunk #6 succeeded at 1511 (offset -40 lines).
  1 out of 6 hunks FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
ffd00e004607b52c2f7e47a857d50f5e5fbac188..01080aabfa7f56d3354f5c4ff78d96ad8f40d305
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1135,45 +1135,6 @@
 crbug.com/524134 [ Win10 ]
paint/invalidation/spv2/selection-gap-transformed-absolute-child.html [
NeedsRebaseline ]
 crbug.com/524134 [ Win10 ]
paint/invalidation/spv2/selection-gap-transformed-fixed-child.html [
NeedsRebaseline ]
 crbug.com/524134 [ Win10 ]
paint/invalidation/spv2/selection-gap-absolute-child.html [ NeedsRebaseline ]
-
-crbug.com/237050 [ Win ] css2.1/t0805-c5518-brdr-t-01-e.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t0805-c5519-brdr-r-00-a.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t0805-c5520-brdr-b-01-e.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t0805-c5521-brdr-l-00-a.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t0805-c5521-brdr-l-01-e.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t0805-c5521-ibrdr-l-00-a.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t090501-c414-flt-01-b.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t090501-c414-flt-03-b-g.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t090501-c414-flt-ln-01-d-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t090501-c5525-flt-l-00-b-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t090501-c5525-flt-r-00-b-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c414-flt-03-c.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c414-flt-04-c.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c414-flt-fit-01-d-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c414-flt-02-c.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c5525-fltblck-01-d.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t0905-c5525-fltcont-00-d-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c5525-fltwidth-00-c-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c5525-fltwidth-02-c-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c5525-fltwidth-03-c-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t0905-c5525-fltwrap-00-b.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] css2.1/t100304-c43-rpl-bbx-01-d-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] css2.1/t1205-c566-list-stl-01-c-g.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] editing/deleting/5144139-2.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/block/positioning/047.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/emphasis.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/emphasis-vertical.html [ NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/fallback-for-custom-font.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/international/text-combine-image-test.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/international/vertical-text-glyph-test.html
[ NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/justify-ideograph-vertical.html [
NeedsRebaseline ]
-crbug.com/237050 [ XP Win7 ] fast/text/midword-break-before-surrogate-pair.html
[ NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/orientation-sideways.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] fast/text/unicode-fallback-font.html [ NeedsRebaseline
]
-crbug.com/237050 [ Win ] fast/writing-mode/english-lr-text.html [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] svg/text/non-bmp-positioning-lists.svg [
NeedsRebaseline ]
-crbug.com/237050 [ Win ] fast/text/regional-indicator-symobls.html [
NeedsRebaseline ]
-crbug.com/237050 [ XP Win7 ]
fast/text/midword-break-before-surrogate-pair-2.html [ NeedsRebaseline ]
 
 # Win10 specific failures that still need triaging.
 crbug.com/521730 [ Win10 ]
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
[ Failure ]
@@ -1316,13 +1277,18 @@
 crbug.com/521730 [ Win10 ] fast/ruby/base-shorter-than-text.html [ Failure
Failure Timeout Failure ]
 crbug.com/521730 [ Win10 ] fast/text/emphasis-combined-text.html [ Failure
Timeout Failure Failure ]
 crbug.com/521730 [ Win10 ] fast/text/emphasis-complex.html [ Failure Timeout
Failure Failure ]
+crbug.com/521730 [ Win10 ] fast/text/emphasis-vertical.html [ Failure Failure
Timeout Failure ]
+crbug.com/521730 [ Win10 ] fast/text/emphasis.html [ Failure Failure Timeout
Failure ]
 crbug.com/521730 [ Win10 ] fast/text/font-weight-variant.html [ Failure Timeout
Failure Failure ]
 crbug.com/521730 [ Win10 ] fast/text/international/003.html [ Failure Timeout
Failure Failure ]
 crbug.com/521730 [ Win10 ] fast/text/international/bold-bengali.html [ Failure
Failure Timeout Failure ]
 crbug.com/521730 [ Win10 ]
fast/text/international/complex-character-based-fallback.html [ Failure Timeout
Timeout Timeout ]
 crbug.com/521730 [ Win10 ] fast/text/international/hindi-spacing.html [ Failure
Failure Failure Timeout ]
 crbug.com/521730 [ Win10 ] fast/text/international/hindi-whitespace.html [
Failure Failure Failure Timeout ]
+#crbug.com/521730 [ Win10 ]
fast/text/international/text-combine-image-test.html [ Failure ]
+#crbug.com/521730 [ Win10 ]
fast/text/international/vertical-text-glyph-test.html [ Failure ]
 crbug.com/521730 [ Win10 ] fast/text/justify-ideograph-leading-expansion.html [
Failure Timeout Failure Timeout ]
+crbug.com/521730 [ Win10 ] fast/text/unicode-fallback-font.html [ Failure
Timeout Failure Timeout ]
 crbug.com/521730 [ Win10 ] fast/writing-mode/Kusa-Makura-background-canvas.html
[ Failure Failure Timeout Failure ]
 crbug.com/521730 [ Win10 ] fast/writing-mode/border-vertical-lr.html [ Failure
Timeout Failure Failure ]
 crbug.com/521730 [ Win10 ] fast/writing-mode/japanese-ruby-vertical-lr.html [
Failure Failure Timeout Failure ]
@@ -1391,6 +1357,7 @@
 crbug.com/521764 [ Win10 ]
editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html [ Failure
Timeout ]
 crbug.com/521764 [ Win10 ]
editing/selection/vertical-rl-ltr-extend-line-forward-br.html [ Failure Timeout
]
 crbug.com/521764 [ Win10 ]
editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html [ Failure
Timeout ]
+crbug.com/521764 [ Win10 ] fast/block/positioning/047.html [ ImageOnlyFailure
Timeout ]
 crbug.com/521764 [ Win10 ] fast/canvas/canvas-lose-restore-googol-size.html [
Failure Pass ]
 crbug.com/521764 [ Win10 ] fast/canvas/canvas-lose-restore-max-int-size.html [
Failure Pass ]
 crbug.com/521764 [ Win10 ] fast/canvas/webgl/texture-color-profile.html [
Failure Pass ]
@@ -1447,8 +1414,11 @@
 crbug.com/521764 [ Win10 ]
fast/text/international/lang-glyph-cache-separation.html [ ImageOnlyFailure
Timeout ]
 crbug.com/521764 [ Win10 ]
fast/text/international/pop-up-button-text-alignment-and-direction.html [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ]
fast/text/international/rtl-white-space-pre-wrap.html [ ImageOnlyFailure Timeout
]
+crbug.com/521764 [ Win10 ] fast/text/international/text-combine-image-test.html
[ Failure Timeout ]
 crbug.com/521764 [ Win10 ] fast/text/international/text-spliced-font.html [
Failure Timeout ]
+crbug.com/521764 [ Win10 ]
fast/text/international/vertical-text-glyph-test.html [ Failure Timeout ]
 crbug.com/521764 [ Win10 ] fast/text/international/wrap-CJK-001.html [ Failure
Timeout ]
+crbug.com/521764 [ Win10 ] fast/text/justify-ideograph-vertical.html [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ] fast/text/midword-break-hang.html [ ImageOnlyFailure
Timeout ]
 crbug.com/521764 [ Win10 ] fast/text/selection-multiple-runs.html [ Failure
Timeout ]
 crbug.com/521764 [ Win10 ] fast/text/stroking.html [ ImageOnlyFailure Timeout ]
@@ -1456,6 +1426,7 @@
 crbug.com/521764 [ Win10 ] fast/text/trailing-white-space.html [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ] fast/text/wide-zero-width-space.html [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ] fast/tokenizer/001.html [ Pass Timeout ]
+crbug.com/521764 [ Win10 ] fast/writing-mode/english-lr-text.html [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ] fast/writing-mode/fallback-orientation.html [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ] fast/writing-mode/japanese-lr-selection.html [
Failure Timeout ]
 crbug.com/521764 [ Win10 ] fast/writing-mode/japanese-lr-text.html [ Failure
Timeout ]
@@ -1541,6 +1512,7 @@
 crbug.com/521764 [ Win10 ] svg/custom/textPath-change-id2-pattern.svg [
ImageOnlyFailure Pass Timeout ]
 crbug.com/521764 [ Win10 ] svg/text/bidi-text-query.svg [ ImageOnlyFailure
Timeout ]
 crbug.com/521764 [ Win10 ] svg/text/bidi-tspans.svg [ ImageOnlyFailure Timeout
]
+crbug.com/521764 [ Win10 ] svg/text/non-bmp-positioning-lists.svg [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ] svg/text/obb-paintserver.html [ ImageOnlyFailure
Pass Timeout ]
 crbug.com/521764 [ Win10 ] svg/text/text-selection-fonts-01-t.svg [
ImageOnlyFailure Timeout ]
 crbug.com/521764 [ Win10 ] svg/text/text-selection-intro-05-t.svg [ Failure
Timeout ]

Powered by Google App Engine
This is Rietveld 408576698