Browser Plugin: <webview> should inherit partition attribute of opener on attachment.

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
@@ skipping 102 matching lines @@
       damage_buffer_sequence_id_(0),
       damage_buffer_size_(0),
       damage_buffer_scale_factor_(1.0f),
       guest_hang_timeout_(
           base::TimeDelta::FromMilliseconds(kHungRendererDelayMs)),
       focused_(false),
       mouse_locked_(false),
       pending_lock_request_(false),
       embedder_visible_(true),
       opener_(NULL),
-      next_permission_request_id_(0) {
+      next_permission_request_id_(0),
+      persist_storage_(false) {
   DCHECK(web_contents);
   web_contents->SetDelegate(this);
   GetWebContents()->GetBrowserPluginGuestManager()->AddGuest(instance_id_,
                                                              GetWebContents());
 }
 
 void BrowserPluginGuest::DestroyUnattachedWindows() {
   // Destroy() reaches in and removes the BrowserPluginGuest from its opener's
   // pending_new_windows_ set. To avoid mutating the set while iterating, we
   // create a copy of the pending new windows set and iterate over the copy.
@@ skipping 50 matching lines @@
 void BrowserPluginGuest::Initialize(
     WebContentsImpl* embedder_web_contents,
     const BrowserPluginHostMsg_CreateGuest_Params& params) {
   focused_ = params.focused;
   guest_visible_ = params.visible;
   if (!params.name.empty())
     name_ = params.name;
   auto_size_enabled_ = params.auto_size_params.enable;
   max_auto_size_ = params.auto_size_params.max_size;
   min_auto_size_ = params.auto_size_params.min_size;
+  if (!params.storage_partition_id.empty()) {
+    storage_partition_id_ = params.storage_partition_id;
+    persist_storage_ = params.persist_storage;
+  }
 
   // Once a BrowserPluginGuest has an embedder WebContents, it's considered to
   // be attached.
   embedder_web_contents_ = embedder_web_contents;
 
   // |render_view_host| manages the ownership of this BrowserPluginGuestHelper.
   new BrowserPluginGuestHelper(this, GetWebContents()->GetRenderViewHost());
 
   RendererPreferences* renderer_prefs =
       GetWebContents()->GetMutableRendererPrefs();
@@ skipping 486 matching lines @@
     // processed the move.  The browser may have ignored the move, but it
     // finished processing.  This is used because the renderer keeps a temporary
     // cache of the widget position while these asynchronous operations are in
     // progress.
     Send(new ViewMsg_Move_ACK(web_contents()->GetRoutingID()));
   }
   // Once a new guest is attached to the DOM of the embedder page, then the
   // lifetime of the new guest is no longer managed by the opener guest.
   opener()->pending_new_windows_.erase(this);
 
+  // The new window inherits the opener's storage partition.
+  storage_partition_id_ = opener()->storage_partition_id_;
+  persist_storage_ = opener()->persist_storage_;
+
   // The guest's frame name takes precedence over the BrowserPlugin's name.
   // The guest's frame name is assigned in
   // BrowserPluginGuest::WebContentsCreated.
   if (!name_.empty())
     params.name.clear();
 
   Initialize(embedder_web_contents, params);
 
   // We initialize the RenderViewHost after a BrowserPlugin has been attached
   // to it and is ready to receive pixels. Until a RenderViewHost is
   // initialized, it will not allow any resize requests.
   if (!GetWebContents()->GetRenderViewHost()->IsRenderViewLive()) {
     static_cast<RenderViewHostImpl*>(
         GetWebContents()->GetRenderViewHost())->Init();
   }
 
-  // Inform the embedder BrowserPlugin of the attached guest.
-  if (!name_.empty()) {
-    SendMessageToEmbedder(
-        new BrowserPluginMsg_UpdatedName(instance_id_, name_));
-  }
+  // Inform the embedder of the guest's information.
+

[lazyboy, 2013/03/25 18:12:55]

nit: remove new line after comment line.

[Fady Samuel, 2013/03/25 19:28:20]

Done.

+  BrowserPluginMsg_Attach_ACK_Params ack_params;
+  ack_params.storage_partition_id = storage_partition_id_;
+  ack_params.persist_storage = persist_storage_;
+  ack_params.name = name_;
+  SendMessageToEmbedder(
+      new BrowserPluginMsg_Attach_ACK(instance_id_, ack_params));
 }
 
 void BrowserPluginGuest::OnDragStatusUpdate(int instance_id,
                                             WebKit::WebDragStatus drag_status,
                                             const WebDropData& drop_data,
                                             WebKit::WebDragOperationsMask mask,
                                             const gfx::Point& location) {
   RenderViewHost* host = GetWebContents()->GetRenderViewHost();
   switch (drag_status) {
     case WebKit::WebDragStatusEnter:
@@ skipping 499 matching lines @@
     LOG(INFO) << "Guest not found. Instance ID: " << instance_id;
     return;
   }
   if (!should_allow)
     guest->Destroy();
   // If we do not destroy the guest then we allow the new window.
   new_window_request_map_.erase(new_window_request_iter);
 }
 
 }  // namespace content