Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1303173010: Move honorEditingBoundaryAtOr{Before,After}() for VisiblePosition to VisibleUnits.cpp (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move honorEditingBoundaryAtOr{Before,After}() for VisiblePosition to VisibleUnits.cpp This patch moves |honorEditingBoundaryAtOr{Before,After}()| for |VisiblePosition| to "VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp" to simpler for improving code health and ease of templatizing |VisiblePosition| class to introduce composed tree version. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201622

Patch Set 1 : 2015-09-02T14:17:25 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -76 lines) Patch
M Source/core/editing/VisiblePosition.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-02 05:30:54 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-09-02 06:48:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303173010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303173010/1
5 years, 3 months ago (2015-09-02 06:50:00 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:55:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201622

Powered by Google App Engine
This is Rietveld 408576698