Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 1303173007: Oilpan: Unship Oilpan from CSSValues Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSCalculationValue.h ('k') | Source/core/css/CSSCalculationValueTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSCalculationValue.cpp
diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp
index 9c51edf952265ded20812e40113988e6e357378f..d3d36236b19fdf5b821ba1f7ad7246da5a47a0b1 100644
--- a/Source/core/css/CSSCalculationValue.cpp
+++ b/Source/core/css/CSSCalculationValue.cpp
@@ -179,22 +179,20 @@ double CSSCalcValue::computeLengthPx(const CSSToLengthConversionData& conversion
return clampToPermittedRange(m_expression->computeLengthPx(conversionData));
}
-DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(CSSCalcExpressionNode)
-
class CSSCalcPrimitiveValue final : public CSSCalcExpressionNode {
- WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(CSSCalcPrimitiveValue);
+ WTF_MAKE_FAST_ALLOCATED(CSSCalcPrimitiveValue);
public:
- static PassRefPtrWillBeRawPtr<CSSCalcPrimitiveValue> create(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> value, bool isInteger)
+ static PassRefPtr<CSSCalcPrimitiveValue> create(PassRefPtr<CSSPrimitiveValue> value, bool isInteger)
{
- return adoptRefWillBeNoop(new CSSCalcPrimitiveValue(value, isInteger));
+ return adoptRef(new CSSCalcPrimitiveValue(value, isInteger));
}
- static PassRefPtrWillBeRawPtr<CSSCalcPrimitiveValue> create(double value, CSSPrimitiveValue::UnitType type, bool isInteger)
+ static PassRefPtr<CSSCalcPrimitiveValue> create(double value, CSSPrimitiveValue::UnitType type, bool isInteger)
{
if (std::isnan(value) || std::isinf(value))
return nullptr;
- return adoptRefWillBeNoop(new CSSCalcPrimitiveValue(CSSPrimitiveValue::create(value, type).get(), isInteger));
+ return adoptRef(new CSSCalcPrimitiveValue(CSSPrimitiveValue::create(value, type).get(), isInteger));
}
bool isZero() const override
@@ -272,20 +270,14 @@ public:
}
- DEFINE_INLINE_VIRTUAL_TRACE()
- {
- visitor->trace(m_value);
- CSSCalcExpressionNode::trace(visitor);
- }
-
private:
- CSSCalcPrimitiveValue(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> value, bool isInteger)
+ CSSCalcPrimitiveValue(PassRefPtr<CSSPrimitiveValue> value, bool isInteger)
: CSSCalcExpressionNode(unitCategory(value->typeWithCalcResolved()), isInteger)
, m_value(value)
{
}
- RefPtrWillBeMember<CSSPrimitiveValue> m_value;
+ RefPtr<CSSPrimitiveValue> m_value;
};
static const CalculationCategory addSubtractResult[CalcOther][CalcOther] = {
@@ -336,7 +328,7 @@ static bool isIntegerResult(const CSSCalcExpressionNode* leftSide, const CSSCalc
class CSSCalcBinaryOperation final : public CSSCalcExpressionNode {
public:
- static PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> create(PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> leftSide, PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> rightSide, CalcOperator op)
+ static PassRefPtr<CSSCalcExpressionNode> create(PassRefPtr<CSSCalcExpressionNode> leftSide, PassRefPtr<CSSCalcExpressionNode> rightSide, CalcOperator op)
{
ASSERT(leftSide->category() != CalcOther && rightSide->category() != CalcOther);
@@ -344,10 +336,10 @@ public:
if (newCategory == CalcOther)
return nullptr;
- return adoptRefWillBeNoop(new CSSCalcBinaryOperation(leftSide, rightSide, op, newCategory));
+ return adoptRef(new CSSCalcBinaryOperation(leftSide, rightSide, op, newCategory));
}
- static PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> createSimplified(PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> leftSide, PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> rightSide, CalcOperator op)
+ static PassRefPtr<CSSCalcExpressionNode> createSimplified(PassRefPtr<CSSCalcExpressionNode> leftSide, PassRefPtr<CSSCalcExpressionNode> rightSide, CalcOperator op)
{
CalculationCategory leftCategory = leftSide->category();
CalculationCategory rightCategory = rightSide->category();
@@ -538,15 +530,8 @@ public:
return CSSPrimitiveValue::UnitType::Unknown;
}
- DEFINE_INLINE_VIRTUAL_TRACE()
- {
- visitor->trace(m_leftSide);
- visitor->trace(m_rightSide);
- CSSCalcExpressionNode::trace(visitor);
- }
-
private:
- CSSCalcBinaryOperation(PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> leftSide, PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> rightSide, CalcOperator op, CalculationCategory category)
+ CSSCalcBinaryOperation(PassRefPtr<CSSCalcExpressionNode> leftSide, PassRefPtr<CSSCalcExpressionNode> rightSide, CalcOperator op, CalculationCategory category)
: CSSCalcExpressionNode(category, isIntegerResult(leftSide.get(), rightSide.get(), op))
, m_leftSide(leftSide)
, m_rightSide(rightSide)
@@ -585,8 +570,8 @@ private:
return 0;
}
- const RefPtrWillBeMember<CSSCalcExpressionNode> m_leftSide;
- const RefPtrWillBeMember<CSSCalcExpressionNode> m_rightSide;
+ const RefPtr<CSSCalcExpressionNode> m_leftSide;
+ const RefPtr<CSSCalcExpressionNode> m_rightSide;
const CalcOperator m_operator;
};
@@ -603,7 +588,7 @@ static ParseState checkDepthAndIndex(int* depth, CSSParserTokenRange tokens)
class CSSCalcExpressionNodeParser {
STACK_ALLOCATED();
public:
- PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> parseCalc(CSSParserTokenRange tokens)
+ PassRefPtr<CSSCalcExpressionNode> parseCalc(CSSParserTokenRange tokens)
{
Value result;
tokens.consumeWhitespace();
@@ -617,7 +602,7 @@ private:
struct Value {
STACK_ALLOCATED();
public:
- RefPtrWillBeMember<CSSCalcExpressionNode> value;
+ RefPtr<CSSCalcExpressionNode> value;
};
char operatorValue(const CSSParserToken& token)
@@ -720,17 +705,17 @@ private:
}
};
-PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> value, bool isInteger)
+PassRefPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode(PassRefPtr<CSSPrimitiveValue> value, bool isInteger)
{
return CSSCalcPrimitiveValue::create(value, isInteger);
}
-PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode(PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> leftSide, PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> rightSide, CalcOperator op)
+PassRefPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode(PassRefPtr<CSSCalcExpressionNode> leftSide, PassRefPtr<CSSCalcExpressionNode> rightSide, CalcOperator op)
{
return CSSCalcBinaryOperation::create(leftSide, rightSide, op);
}
-PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode(double pixels, double percent)
+PassRefPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode(double pixels, double percent)
{
return createExpressionNode(
createExpressionNode(CSSPrimitiveValue::create(pixels, CSSPrimitiveValue::UnitType::Pixels), pixels == trunc(pixels)),
@@ -738,17 +723,17 @@ PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode
CalcAdd);
}
-PassRefPtrWillBeRawPtr<CSSCalcValue> CSSCalcValue::create(const CSSParserTokenRange& tokens, ValueRange range)
+PassRefPtr<CSSCalcValue> CSSCalcValue::create(const CSSParserTokenRange& tokens, ValueRange range)
{
CSSCalcExpressionNodeParser parser;
- RefPtrWillBeRawPtr<CSSCalcExpressionNode> expression = parser.parseCalc(tokens);
+ RefPtr<CSSCalcExpressionNode> expression = parser.parseCalc(tokens);
- return expression ? adoptRefWillBeNoop(new CSSCalcValue(expression, range)) : nullptr;
+ return expression ? adoptRef(new CSSCalcValue(expression, range)) : nullptr;
}
-PassRefPtrWillBeRawPtr<CSSCalcValue> CSSCalcValue::create(PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> expression, ValueRange range)
+PassRefPtr<CSSCalcValue> CSSCalcValue::create(PassRefPtr<CSSCalcExpressionNode> expression, ValueRange range)
{
- return adoptRefWillBeNoop(new CSSCalcValue(expression, range));
+ return adoptRef(new CSSCalcValue(expression, range));
}
} // namespace blink
« no previous file with comments | « Source/core/css/CSSCalculationValue.h ('k') | Source/core/css/CSSCalculationValueTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698