Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1303163008: Allow default font size changing on Linux. (Closed)

Created:
5 years, 3 months ago by kochi
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, nasko+codewatch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, arv+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow default font size changing on Linux. Currently base rendering font size on Linux is hardcoded to 16.0 with no possibility of changing it. This patch add such possibility in RendererPreferences. Webkit part: https://codereview.chromium.org/570243002/ This was once landed and reverted: https://codereview.chromium.org/549303004 (original) https://codereview.chromium.org/1319613004 (revert) due to unexpected default font size change. Now this CL removes the problematic part to derive the default font size from desktop environment. BUG=525176 TBR=joleksy@opera.com, jochen@chromium.org, erg@chromium.org, jln@chromium.org Committed: https://crrev.com/b48e1b8c1aaf9b9ea0f397b57e979ba4384a09e2 Cr-Commit-Position: refs/heads/master@{#346353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow_test.unitjs View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/renderer_preferences.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/renderer_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_linux.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kochi
5 years, 3 months ago (2015-08-31 06:02:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303163008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303163008/1
5 years, 3 months ago (2015-08-31 06:03:01 UTC) #3
kochi
Now with correct TBR addresses.
5 years, 3 months ago (2015-08-31 06:10:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 07:32:37 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 07:33:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b48e1b8c1aaf9b9ea0f397b57e979ba4384a09e2
Cr-Commit-Position: refs/heads/master@{#346353}

Powered by Google App Engine
This is Rietveld 408576698