Introduce composed tree version of directionOfEnclosingBlock()

Introduce composed tree version of directionOfEnclosingBlock()

This patch introduces composed tree version of |directionOfEnclosingBlock()|
as a preparation of introducing composed tree version of |VisiblePosition|
for a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201377

[yosin_UTC9, 2015-08-28 02:14:38]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-08-28 02:19:38]

PTAL

[yoichio, 2015-08-28 02:26:17]

lgtm

https://codereview.chromium.org/1303163006/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1303163006/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilities.cpp:699: Element* enclosingBlockElement =
enclosingBlock(position, CannotCrossEditingBoundary);
This replacement means 
|firstPositionInOrBeforeNode(position.computeContainerNode())|
 === |position|.
Is that true?

[yoichio, 2015-08-28 02:26:31]

nlgtm

[yoichio, 2015-08-28 02:27:29]

not LGTM

[yosin_UTC9, 2015-08-28 05:45:11]

PTAL

https://codereview.chromium.org/1303163006/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1303163006/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilities.cpp:699: Element* enclosingBlockElement =
enclosingBlock(position, CannotCrossEditingBoundary);
On 2015/08/28 02:26:17, yoichio wrote:
> This replacement means 
> |firstPositionInOrBeforeNode(position.computeContainerNode())|
>  === |position|.
> Is that true?

No, we should pass Position(position.computeContainerNode())

[yoichio, 2015-08-28 05:55:23]

https://codereview.chromium.org/1303163006/diff/20001/Source/core/editing/Edi...
File Source/core/editing/EditingUtilities.cpp (left):

https://codereview.chromium.org/1303163006/diff/20001/Source/core/editing/Edi...
Source/core/editing/EditingUtilities.cpp:698: Element* enclosingBlockElement =
enclosingBlock(position.computeContainerNode());
enclosingBlock has DOM/InComposition overrides so why do you code just like 
|enclosingBlock(position)| ?

[yosin_UTC9, 2015-08-28 06:22:58]

https://codereview.chromium.org/1303163006/diff/20001/Source/core/editing/Edi...
File Source/core/editing/EditingUtilities.cpp (left):

https://codereview.chromium.org/1303163006/diff/20001/Source/core/editing/Edi...
Source/core/editing/EditingUtilities.cpp:698: Element* enclosingBlockElement =
enclosingBlock(position.computeContainerNode());
On 2015/08/28 05:55:23, yoichio wrote:
> enclosingBlock has DOM/InComposition overrides so why do you code just like 
> |enclosingBlock(position)| ?

PS#1 does |enclosingBlock(position)|, however as you said in comment:

enclosingBlock(position.computeContainerNode())
== enclosingBlock(firstPositionInOrBeforeNode(position.computeContainerNode())

So, PS#2 passes
PositionAlgorithm<Strategy>::firstPositionInOrBeforeNode(position.computeContainerNode())

[yoichio, 2015-08-28 06:30:13]

Oh, I was confused.
lgtm

[yosin_UTC9, 2015-08-28 06:30:36]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-28 06:30:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303163006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303163006/20001

[commit-bot: I haz the power, 2015-08-28 06:44:50]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201377