Revert of Make NavigationScheduler post loading tasks instead of timers

Revert of Make NavigationScheduler post loading tasks instead of timers (patchset #1 id:1 of https://codereview.chromium.org/1305933007/ )

Reason for revert:
I think this is causing timeouts: http://crbug.com/528352.

Original issue's description:
> Make NavigationScheduler post loading tasks instead of timers
> 
> Similar to https://codereview.chromium.org/1312353004/
> 
> We would like to be able to prioritize loading tasks, but in order to
> do that we need to make sure loading tasks are posted to the right queue
> to make sure tasks run in the expected order.  If this task is posted as
> a timer, and loading tasks are prioritzed, it's possible
> FrameHostMsg_DidStopLoading will be sent before the corresponding
> FrameHostMsg_DidStartLoading ipc which causes various browser tests to
> break.
> 
> Must be submitted after https://codereview.chromium.org/1303153005/
> 
> BUG=497761, 510398
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201780

TBR=skyostil@chromium.org,haraken@chromium.org,sigbjornf@opera.com,alexclarke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497761, 510398

[pdr., 2015-09-04 17:29:42]

Created Revert of Make NavigationScheduler post loading tasks instead of timers

[commit-bot: I haz the power, 2015-09-04 17:29:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303153008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303153008/1

[commit-bot: I haz the power, 2015-09-04 17:30:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 17:30:19]

Failed to apply patch for Source/core/loader/NavigationScheduler.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/loader/NavigationScheduler.cpp
  Hunk #1 FAILED at 48.
  Hunk #2 FAILED at 267.
  Hunk #3 succeeded at 373 (offset 1 line).
  Hunk #4 FAILED at 414.
  3 out of 4 hunks FAILED -- saving rejects to file
Source/core/loader/NavigationScheduler.cpp.rej

Patch:       Source/core/loader/NavigationScheduler.cpp
Index: Source/core/loader/NavigationScheduler.cpp
diff --git a/Source/core/loader/NavigationScheduler.cpp
b/Source/core/loader/NavigationScheduler.cpp
index
fb383ba36357f39070c5ddb80384382b3addf2c4..2841a7980c71c1b8148245126de3899c5819f461
100644
--- a/Source/core/loader/NavigationScheduler.cpp
+++ b/Source/core/loader/NavigationScheduler.cpp
@@ -48,7 +48,6 @@
 #include "core/page/Page.h"
 #include "platform/SharedBuffer.h"
 #include "platform/UserGestureIndicator.h"
-#include "public/platform/Platform.h"
 #include "wtf/CurrentTime.h"
 
 namespace blink {
@@ -267,7 +266,7 @@
 
 NavigationScheduler::NavigationScheduler(LocalFrame* frame)
     : m_frame(frame)
-    , m_navigateTaskFactory(WTF::bind(&NavigationScheduler::navigateTask,
this))
+    , m_timer(this, &NavigationScheduler::timerFired)
     , m_navigationDisableCount(0)
 {
 }
@@ -372,7 +371,7 @@
     schedule(ScheduledReload::create());
 }
 
-void NavigationScheduler::navigateTask()
+void NavigationScheduler::timerFired(Timer<NavigationScheduler>*)
 {
     if (!m_frame->page())
         return;
@@ -414,22 +413,20 @@
         return;
 
     ASSERT(m_frame->page());
-    if (m_navigateTaskFactory.isPending())
+    if (m_timer.isActive())
         return;
     if (!m_redirect->shouldStartTimer(m_frame))
         return;
 
-   
Platform::current()->currentThread()->scheduler()->loadingTaskRunner()->postDelayedTask(
-        FROM_HERE, m_navigateTaskFactory.cancelAndCreate(),
m_redirect->delay());
-
+    m_timer.startOneShot(m_redirect->delay(), FROM_HERE);
     InspectorInstrumentation::frameScheduledNavigation(m_frame,
m_redirect->delay());
 }
 
 void NavigationScheduler::cancel()
 {
-    if (m_navigateTaskFactory.isPending())
+    if (m_timer.isActive())
         InspectorInstrumentation::frameClearedScheduledNavigation(m_frame);
-    m_navigateTaskFactory.cancel();
+    m_timer.stop();
     m_redirect.clear();
 }

[haraken, 2015-09-04 17:41:17]

LGTM

[pdr., 2015-09-04 17:43:30]

On 2015/09/04 at 17:41:17, haraken wrote:
> LGTM

Talked with alex offline. I'm going to suppress the test for now.