Source/modules/webaudio/AsyncAudioDecoder.cpp - Issue 1303153005: Introduce WebTaskRunner Patch 3/5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AsyncAudioDecoder.cpp

Issue 1303153005: Introduce WebTaskRunner Patch 3/5 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/webaudio/AbstractAudioContext.cpp ('k') | Source/modules/webaudio/DeferredTaskHandler.cpp » ('j') | Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AsyncAudioDecoder.cpp

diff --git a/Source/modules/webaudio/AsyncAudioDecoder.cpp b/Source/modules/webaudio/AsyncAudioDecoder.cpp

index c3b98ba1f397dfd967986a14d8b459d038dd7657..3420f1c07211dbd81aa250164b1c39b835bf14b2 100644

--- a/Source/modules/webaudio/AsyncAudioDecoder.cpp

+++ b/Source/modules/webaudio/AsyncAudioDecoder.cpp

@@ -60,7 +60,7 @@ void AsyncAudioDecoder::decodeAsync(DOMArrayBuffer* audioData, float sampleRate,

RefPtr<DOMArrayBuffer> audioDataRef(audioData);

// The leak references to successCallback and errorCallback are picked up on notifyComplete.

- m_thread->postTask(FROM_HERE, new Task(threadSafeBind(&AsyncAudioDecoder::decode, AllowCrossThreadAccess(audioDataRef.release().leakRef()), sampleRate, successCallback, errorCallback)));

+ m_thread->defaultTaskRunner()->postTask(FROM_HERE, new Task(threadSafeBind(&AsyncAudioDecoder::decode, AllowCrossThreadAccess(audioDataRef.release().leakRef()), sampleRate, successCallback, errorCallback)));

}

void AsyncAudioDecoder::decode(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback)

@@ -69,7 +69,7 @@ void AsyncAudioDecoder::decode(DOMArrayBuffer* audioData, float sampleRate, Audi

// Decoding is finished, but we need to do the callbacks on the main thread.

// The leaked reference to audioBuffer is picked up in notifyComplete.

- Platform::current()->mainThread()->postTask(FROM_HERE, threadSafeBind(&AsyncAudioDecoder::notifyComplete, AllowCrossThreadAccess(audioData), successCallback, errorCallback, bus.release().leakRef()));

+ Platform::current()->mainThread()->defaultTaskRunner()->postTask(FROM_HERE, threadSafeBind(&AsyncAudioDecoder::notifyComplete, AllowCrossThreadAccess(audioData), successCallback, errorCallback, bus.release().leakRef()));

}

void AsyncAudioDecoder::notifyComplete(DOMArrayBuffer* audioData, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, AudioBus* audioBus)