Source/modules/compositorworker/CompositorWorkerManagerTest.cpp - Issue 1303153005: Introduce WebTaskRunner Patch 3/5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/compositorworker/CompositorWorkerManagerTest.cpp

Issue 1303153005: Introduce WebTaskRunner Patch 3/5 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/compositorworker/CompositorWorkerManager.cpp ('k') | Source/modules/fetch/CompositeDataConsumerHandle.cpp » ('j') | Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/compositorworker/CompositorWorkerManagerTest.cpp

diff --git a/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp b/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp

index 76ad7dbd774b7296c4ea41b087b16ac1bc75388e..5813f438e20a908d4a1c6832f6574f5661a5e380 100644

--- a/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp

+++ b/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp

@@ -132,7 +132,7 @@ public:

void checkWorkerCanExecuteScript(WorkerThread* worker)

{

OwnPtr<WebWaitableEvent> waitEvent = adoptPtr(Platform::current()->createWaitableEvent());

- worker->backingThread().platformThread().postTask(FROM_HERE, threadSafeBind(&CompositorWorkerManagerTest::executeScriptInWorker, AllowCrossThreadAccess(this),

+ worker->backingThread().platformThread().defaultTaskRunner()->postTask(FROM_HERE, threadSafeBind(&CompositorWorkerManagerTest::executeScriptInWorker, AllowCrossThreadAccess(this),

AllowCrossThreadAccess(worker), AllowCrossThreadAccess(waitEvent.get())));

waitEvent->wait();

}

@@ -237,7 +237,7 @@ TEST_F(CompositorWorkerManagerTest, TerminateFirstAndCreateSecond)

// Jump over to the worker's thread to verify that the Isolate is set up correctly and execute script.

OwnPtr<WebWaitableEvent> checkEvent = adoptPtr(Platform::current()->createWaitableEvent());

- secondThread->platformThread().postTask(FROM_HERE, threadSafeBind(&checkCurrentIsolate, AllowCrossThreadAccess(compositorWorker->isolate()), AllowCrossThreadAccess(checkEvent.get())));

+ secondThread->platformThread().defaultTaskRunner()->postTask(FROM_HERE, threadSafeBind(&checkCurrentIsolate, AllowCrossThreadAccess(compositorWorker->isolate()), AllowCrossThreadAccess(checkEvent.get())));

waitForWaitableEventAfterIteratingCurrentLoop(checkEvent.get());

checkWorkerCanExecuteScript(compositorWorker.get());