Make correct GL context current during gpu_tracer processing

Make correct GL context current during gpu_tracer processing

The gpu_tracer reads back GL timer queries as a delayed task.
During processing the associated GL context wasn't made current, so it
was possible to query the wrong context, get incorrect timestamps, or
cause GL errors.

BUG=331161
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244068

[vmiura, 2014-01-09 01:42:13]

Please take a look.

[piman, 2014-01-09 02:10:33]

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2219: gpu_tracer_ =
GPUTracer::Create(base::AsWeakPtr(this));
Can we avoid weak pointers? Since |gpu_tracer_| is owned by |this|, the decoder
will outlive the GPUTracer.

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gpu_tracer.cc (right):

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
gpu/command_buffer/service/gpu_tracer.cc:208: decoder_->MakeCurrent();
note: MakeCurrent can fail (e.g. lost context). In that case, you should at
least skip making the GL calls (since the context is not current).

[vmiura, 2014-01-09 02:57:02]

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2219: gpu_tracer_ =
GPUTracer::Create(base::AsWeakPtr(this));
On 2014/01/09 02:10:33, piman wrote:
> Can we avoid weak pointers? Since |gpu_tracer_| is owned by |this|, the
decoder
> will outlive the GPUTracer.

Done.

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gpu_tracer.cc (right):

https://codereview.chromium.org/130313002/diff/70001/gpu/command_buffer/servi...
gpu/command_buffer/service/gpu_tracer.cc:208: decoder_->MakeCurrent();
On 2014/01/09 02:10:33, piman wrote:
> note: MakeCurrent can fail (e.g. lost context). In that case, you should at
> least skip making the GL calls (since the context is not current).

Done.

In this case I will skip all GL calls, including releasing of query objects.
I assume that's OK since we lost the context.

[piman, 2014-01-09 03:36:37]

lgtm

[commit-bot: I haz the power, 2014-01-09 19:27:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vmiura@chromium.org/130313002/170001

[commit-bot: I haz the power, 2014-01-09 22:05:25]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-09 23:22:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vmiura@chromium.org/130313002/170001

[commit-bot: I haz the power, 2014-01-10 03:18:10]

Change committed as 244068