Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1303123002: Revert of Adding support for Smart GO NEXT feature in Android Chrome (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
lgombos, AKV, kochi
CC:
blink-reviews, dglazkov+blink, AKVT, yosin_UTC9, bcwhite, Avi (use Gerrit), lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of Adding support for Smart GO NEXT feature in Android Chrome (patchset #23 id:460001 of https://codereview.chromium.org/939603002/ ) Reason for revert: Regression in power.android_acceptance. crbug.com/520952 Original issue's description: > Adding support for Smart GO NEXT feature in Android Chrome > > This change takes care of providing easy navigation among text input > elements inside a form. > > Corresponding changes to control the PREVIOUS, NEXT and GO button is done > at https://codereview.chromium.org/1080693002/ > > BUG=410785 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200398 TBR=kochi@chromium.org,l.gombos@samsung.com,ajith.v@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=410785, 520952 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200948

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Remove DocumentMarkerController.h include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -455 lines) Patch
M Source/web/WebViewImpl.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 chunks +0 lines, -71 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 1 chunk +0 lines, -314 lines 0 comments Download
D Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
D Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html View 1 1 chunk +0 lines, -12 lines 0 comments Download
M public/web/WebTextInputType.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M public/web/WebView.h View 1 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Created Revert of Adding support for Smart GO NEXT feature in Android Chrome
5 years, 4 months ago (2015-08-21 00:39:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303123002/1
5 years, 4 months ago (2015-08-21 00:39:39 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/web/WebViewImpl.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 4 months ago (2015-08-21 00:40:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303123002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303123002/220001
5 years, 4 months ago (2015-08-21 01:52:30 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 01:53:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:220001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200948

Powered by Google App Engine
This is Rietveld 408576698