Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303103003: PDF: Use PDF metadata for the title instead of the last path element. (Closed)

Created:
5 years, 3 months ago by Sam McNally
Modified:
5 years, 3 months ago
Reviewers:
raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Use PDF metadata for the title instead of the last path element. Committed: https://crrev.com/2dd06eeefec484e31debecc4552ddd3f3cf96726 Cr-Commit-Position: refs/heads/master@{#345838}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -35 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 2 3 4 3 chunks +10 lines, -5 lines 0 comments Download
M chrome/test/data/pdf/basic_plugin_test.js View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/pdf/test-title.pdf View Binary file 0 comments Download
A chrome/test/data/pdf/title_test.js View 1 chunk +19 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M pdf/pdf_engine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_api_string_buffer_adapter.h View 1 2 3 chunks +47 lines, -1 line 0 comments Download
M pdf/pdfium/pdfium_api_string_buffer_adapter.cc View 1 2 3 chunks +28 lines, -7 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 3 4 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
Sam McNally
5 years, 3 months ago (2015-08-26 05:17:05 UTC) #3
raymes
https://codereview.chromium.org/1303103003/diff/20001/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1303103003/diff/20001/pdf/pdfium/pdfium_engine.cc#newcode527 pdf/pdfium/pdfium_engine.cc:527: size_t buffer_size = FPDFBookmark_GetTitle(bookmark, NULL, 0); Should we keep ...
5 years, 3 months ago (2015-08-26 06:33:15 UTC) #4
Sam McNally
https://codereview.chromium.org/1303103003/diff/20001/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1303103003/diff/20001/pdf/pdfium/pdfium_engine.cc#newcode527 pdf/pdfium/pdfium_engine.cc:527: size_t buffer_size = FPDFBookmark_GetTitle(bookmark, NULL, 0); On 2015/08/26 06:33:15, ...
5 years, 3 months ago (2015-08-26 08:23:11 UTC) #5
raymes
lgtm https://codereview.chromium.org/1303103003/diff/80001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1303103003/diff/80001/chrome/browser/resources/pdf/pdf.js#newcode617 chrome/browser/resources/pdf/pdf.js:617: if (this.bookmarks_.length !== 0) I wonder if we ...
5 years, 3 months ago (2015-08-27 04:07:37 UTC) #6
Sam McNally
https://codereview.chromium.org/1303103003/diff/80001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1303103003/diff/80001/chrome/browser/resources/pdf/pdf.js#newcode617 chrome/browser/resources/pdf/pdf.js:617: if (this.bookmarks_.length !== 0) On 2015/08/27 04:07:37, raymes wrote: ...
5 years, 3 months ago (2015-08-27 04:18:48 UTC) #7
Sam McNally
PTAL https://codereview.chromium.org/1303103003/diff/80001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1303103003/diff/80001/chrome/browser/resources/pdf/pdf.js#newcode617 chrome/browser/resources/pdf/pdf.js:617: if (this.bookmarks_.length !== 0) On 2015/08/27 04:07:37, raymes ...
5 years, 3 months ago (2015-08-27 04:43:31 UTC) #8
raymes
lgtm! thanks for that :)
5 years, 3 months ago (2015-08-27 04:44:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303103003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303103003/100001
5 years, 3 months ago (2015-08-27 04:48:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99296)
5 years, 3 months ago (2015-08-27 06:41:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303103003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303103003/100001
5 years, 3 months ago (2015-08-27 06:42:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99328)
5 years, 3 months ago (2015-08-27 08:15:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303103003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303103003/100001
5 years, 3 months ago (2015-08-27 08:16:55 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 3 months ago (2015-08-27 10:25:43 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 10:26:39 UTC) #21
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/2dd06eeefec484e31debecc4552ddd3f3cf96726
Cr-Commit-Position: refs/heads/master@{#345838}

Powered by Google App Engine
This is Rietveld 408576698