Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 1303063010: clang/win: Make dump_file_system.cc build. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Make dump_file_system.cc build. In clang/win/gn builds, this file warned: ../../storage/browser/fileapi/dump_file_system.cc(96,71) : error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror,-Wreserved-user-defined-literal] ShowMessageAndExit(base::StringPrintf("GetFileInfo failed for %"PRId64, ^ In gyp builds, nothing in build/all.gyp depends on this target, and in non-Win gn src/BUILD.gn blacklists this target. So this warning is only seen on clang/win gn builds. No behavior change. BUG=491209 TBR=tzik Committed: https://chromium.googlesource.com/chromium/src/+/10531819b506d7e8b6b6415f5da8882885f4d779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M storage/browser/fileapi/dump_file_system.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
5 years, 3 months ago (2015-09-01 23:23:34 UTC) #2
Nico
Committed patchset #1 (id:1) manually as 10531819b506d7e8b6b6415f5da8882885f4d779 (presubmit successful).
5 years, 3 months ago (2015-09-01 23:27:29 UTC) #3
tzik
5 years, 3 months ago (2015-09-02 05:31:43 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698