Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1303063008: DM: "wb" (binary mode) may matter on Windows (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
stephana, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: "wb" (binary mode) may matter on Windows I suspect we might be doing some funky /n -> /r/n translations without 'b'. This kills the PNG. BUG=skia: NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/c64137c245dd24be54f37d762c0855bd719cb3ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303063008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303063008/1
5 years, 4 months ago (2015-08-25 17:45:14 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-25 17:45:21 UTC) #4
stephana
On 2015/08/25 17:45:21, mtklein_C wrote: lgtm
5 years, 4 months ago (2015-08-25 17:53:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303063008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303063008/1
5 years, 4 months ago (2015-08-25 17:55:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303063008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303063008/1
5 years, 4 months ago (2015-08-25 17:55:44 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 17:56:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c64137c245dd24be54f37d762c0855bd719cb3ad

Powered by Google App Engine
This is Rietveld 408576698