Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1303063005: Use chromium committer list from chrome-infra-auth (Closed)

Created:
5 years, 4 months ago by Sergiy Byelozyorov
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use chromium committer list from chrome-infra-auth R=phajdan.jr@chromium.org BUG=511311 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201134

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 12 (4 generated)
Sergiy Byelozyorov
5 years, 4 months ago (2015-08-25 01:57:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303063005/1
5 years, 4 months ago (2015-08-25 01:57:33 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-25 02:41:01 UTC) #5
Paweł Hajdan Jr.
LGTM
5 years, 4 months ago (2015-08-25 10:13:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303063005/1
5 years, 4 months ago (2015-08-25 15:10:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201134
5 years, 4 months ago (2015-08-25 15:14:52 UTC) #9
Adrian Kuegel
https://codereview.chromium.org/1303063005/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1303063005/diff/1/infra/config/cq.cfg#newcode22 infra/config/cq.cfg:22: committer_list: "project-chromium-committers" I think it should be "external/project-chromium-committers"
5 years, 4 months ago (2015-08-25 15:48:03 UTC) #11
Sergiy Byelozyorov
5 years, 4 months ago (2015-08-25 16:04:38 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1303063005/diff/1/infra/config/cq.cfg
File infra/config/cq.cfg (right):

https://codereview.chromium.org/1303063005/diff/1/infra/config/cq.cfg#newcode22
infra/config/cq.cfg:22: committer_list: "project-chromium-committers"
On 2015/08/25 15:48:03, Adrian Kuegel wrote:
> I think it should be "external/project-chromium-committers"

Indeed. Thanks for fixing it.

Powered by Google App Engine
This is Rietveld 408576698