Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 1303033010: Navigation extension point. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweaks Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/plugin/navigation.dart ('k') | pkg/analysis_server/lib/src/collections.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 87c65090fe8433211f1ef85d555e3ad5a15288f8..5d0fb7d780c78ad2c8ff1bdd0ba1ebc768f80398 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -961,6 +961,9 @@ class AnalysisServer {
// Dart unit notifications.
if (AnalysisEngine.isDartFileName(file)) {
Source source = contextSource.source;
+ // TODO(scheglov) This way to get resolved information is very Dart
+ // specific. OTOH as it is planned now Angular results are not
+ // flushable.
CompilationUnit dartUnit =
_getResolvedCompilationUnitToResendNotification(context, source);
if (dartUnit != null) {
@@ -969,8 +972,7 @@ class AnalysisServer {
sendAnalysisNotificationHighlights(this, file, dartUnit);
break;
case AnalysisService.NAVIGATION:
- // TODO(scheglov) consider support for one unit in 2+ libraries
- sendAnalysisNotificationNavigation(this, file, dartUnit);
+ sendAnalysisNotificationNavigation(this, context, source);
break;
case AnalysisService.OCCURRENCES:
sendAnalysisNotificationOccurrences(this, file, dartUnit);
« no previous file with comments | « pkg/analysis_server/lib/plugin/navigation.dart ('k') | pkg/analysis_server/lib/src/collections.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698