Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1303033004: Split up mixed content devtools test into 3 separate tests (Closed)

Created:
5 years, 4 months ago by estark
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Split up mixed content devtools test into 3 separate tests When testing all three mixed content types in one test, the test was flaky because DevTools received requestWillBeSent events in different orders. Instead of making sure that the requests are always sent in the same order, this CL splits up the test into 3 separate tests, one for each mixed content type, with common code in resources/mixed-content-type-test.js. BUG=523500 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201247

Patch Set 1 #

Patch Set 2 : rebase, and remove request-mixed-content-status.html flaky expectation #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -83 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/inspector-protocol/request-mixed-content-status.html View 1 chunk +0 lines, -70 lines 0 comments Download
A LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-blockable.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-blockable-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
D LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-none.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-none-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-optionally-blockable.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-optionally-blockable-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-protocol/resources/mixed-content-type-test.js View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
estark
pfeldman: PTAL? This simplifies the mixed content devtools test by splitting it into 3 tests ...
5 years, 4 months ago (2015-08-21 21:28:23 UTC) #2
pfeldman
lgtm
5 years, 4 months ago (2015-08-24 17:44:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033004/20001
5 years, 4 months ago (2015-08-24 17:52:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103198)
5 years, 4 months ago (2015-08-24 18:22:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033004/20001
5 years, 4 months ago (2015-08-24 18:37:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103241)
5 years, 4 months ago (2015-08-24 19:07:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033004/20001
5 years, 4 months ago (2015-08-24 22:20:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103388)
5 years, 4 months ago (2015-08-24 22:45:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033004/20001
5 years, 3 months ago (2015-08-26 20:03:02 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/61794) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-08-26 20:04:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033004/40001
5 years, 3 months ago (2015-08-26 20:10:13 UTC) #23
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 20:52:36 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201247

Powered by Google App Engine
This is Rietveld 408576698