Fix function scoping issue

Fix function scoping issue

The parser has special behavior with respect to the bindings
of inner functions in sloppy mode which are not at the top
level of scopes. This behavior should be turned off when the
--harmony-sloppy-function flag is set, as lexical scoping
rules are used instead. Previously, the incorrect flag
--harmony-sloppy was used, resulting in a crashing bug.

BUG=chromium:520029
LOG=Y
R=adamk

Committed: https://crrev.com/9c79e69e6c9725501852a26de1d0284e6aad038d
Cr-Commit-Position: refs/heads/master@{#30315}

[Dan Ehrenberg, 2015-08-21 00:34:26]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-21 00:34:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303033003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303033003/1

[commit-bot: I haz the power, 2015-08-21 01:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 01:02:25]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2015-08-21 18:36:55]

littledan@chromium.org changed reviewers:
+ adamk@chromium.org

[Dan Ehrenberg, 2015-08-21 21:09:57]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-21 21:10:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303033003/20001

[commit-bot: I haz the power, 2015-08-21 21:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 21:34:29]

Dry run: This issue passed the CQ dry run.

[adamk, 2015-08-21 21:39:04]

Code looks fine, some questions about the test.

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-520029.js (right):

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-520029.js:28: try {
Is this try/catch doing anything?

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-520029.js:34: function __f_21() { }
Is this function doing anything?

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-520029.js:45: }, ReferenceError);
Sorry, I'm missing something; why does this cause a reference error?

[Dan Ehrenberg, 2015-08-21 23:04:31]

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-520029.js (right):

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-520029.js:28: try {
On 2015/08/21 at 21:39:04, adamk wrote:
> Is this try/catch doing anything?

Yes, it's defining a function __f_14() which references a lexically scoped local
variable. I had thought that this was enough to trigger
https://code.google.com/p/chromium/issues/detail?id=520891 , but apparently not.
I dedup'd that bug and deleted this "test".

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-520029.js:34: function __f_21() { }
On 2015/08/21 at 21:39:04, adamk wrote:
> Is this function doing anything?

Not sure, it does something to the scopes but I actually can't repro the
original issue (see below).

https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-520029.js:45: }, ReferenceError);
On 2015/08/21 at 21:39:04, adamk wrote:
> Sorry, I'm missing something; why does this cause a reference error?

You're right, this doesn't actually make sense. Another case of me misdiagnosing
a dup bug, and quickly concluding that I fixed it just because it didn't crash
the parser with this patch (it didn't before either). Removed this from the
test.

[adamk, 2015-08-21 23:40:56]

lgtm

[Dan Ehrenberg, 2015-08-21 23:53:19]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2015-08-21 23:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303033003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303033003/40001

[commit-bot: I haz the power, 2015-08-22 00:18:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-22 00:18:37]

Patchset 3 (id:??) landed as
https://crrev.com/9c79e69e6c9725501852a26de1d0284e6aad038d
Cr-Commit-Position: refs/heads/master@{#30315}