Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303033002: asABitmap is deprecated, switch over to (simpler) isABitmap (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
f(malita), reed2, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

asABitmap is deprecated, switch over to (simpler) isABitmap BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=vmpstr Committed: https://crrev.com/594dd2ceb850729071c042c591264538b44f8c6d Cr-Commit-Position: refs/heads/master@{#347633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M cc/raster/tile_task_worker_pool.cc View 1 chunk +1 line, -8 lines 0 comments Download
M skia/ext/pixel_ref_utils.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033002/1
5 years, 4 months ago (2015-08-21 03:11:09 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-21 05:39:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033002/1
5 years, 3 months ago (2015-08-31 10:33:57 UTC) #6
reed1
ptal
5 years, 3 months ago (2015-08-31 10:36:32 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/97832)
5 years, 3 months ago (2015-08-31 11:48:52 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033002/1
5 years, 3 months ago (2015-08-31 12:35:29 UTC) #12
f(malita)
lgtm
5 years, 3 months ago (2015-08-31 13:06:42 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 13:14:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303033002/1
5 years, 3 months ago (2015-09-07 13:29:04 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 14:48:50 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 14:49:23 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/594dd2ceb850729071c042c591264538b44f8c6d
Cr-Commit-Position: refs/heads/master@{#347633}

Powered by Google App Engine
This is Rietveld 408576698