Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 130303004: Retrieve the authenticated user's e-mail from GAIA during SAML enrollment (Closed)

Created:
6 years, 11 months ago by bartfab (slow)
Modified:
6 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Retrieve the authenticated user's e-mail from GAIA during SAML enrollment This CL is the equivalent of CL 136573002 for enrollment: It ensures that when a user authenticates via SAML during enrollment, that user's e-mail address is used to enroll the device. BUG=332132 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245202

Patch Set 1 #

Patch Set 2 : Fix conflict between enrollment and login message handler.s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 1 4 chunks +33 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bartfab (slow)
Hi Xiyuan, Could you please review?
6 years, 11 months ago (2014-01-15 16:28:08 UTC) #1
xiyuan
lgtm
6 years, 11 months ago (2014-01-15 17:27:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/130303004/60001
6 years, 11 months ago (2014-01-16 10:24:12 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247225
6 years, 11 months ago (2014-01-16 13:02:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/130303004/60001
6 years, 11 months ago (2014-01-16 13:06:47 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 15:56:24 UTC) #6
Message was sent while issue was closed.
Change committed as 245202

Powered by Google App Engine
This is Rietveld 408576698