Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1303003002: Fix handling unknown branches when parsing switch instructions. (Closed)

Created:
5 years, 4 months ago by Karl
Modified:
5 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix handling unknown branches when parsing switch instructions. The bitcode reader for the switch insruction did not check if the branch labels were defined. This patch fixes the problem. Includes test for such a case. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0042fea38a41488f6da0e49fbe810fcb3bb88622

Patch Set 1 #

Patch Set 2 : fix nit. #

Total comments: 2

Patch Set 3 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/PNaClTranslator.cpp View 1 3 chunks +9 lines, -5 lines 0 comments Download
A + tests_lit/parse_errs/Inputs/bad-switch-case.tbc View 1 chunk +7 lines, -3 lines 0 comments Download
A tests_lit/parse_errs/bad-switch-case.test View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 4 months ago (2015-08-20 20:31:14 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1303003002/diff/20001/tests_lit/parse_errs/bad-switch-case.test File tests_lit/parse_errs/bad-switch-case.test (right): https://codereview.chromium.org/1303003002/diff/20001/tests_lit/parse_errs/bad-switch-case.test#newcode1 tests_lit/parse_errs/bad-switch-case.test:1: Remove blank lines at beginning and end of ...
5 years, 4 months ago (2015-08-20 21:18:04 UTC) #3
Karl
Committed patchset #3 (id:40001) manually as 0042fea38a41488f6da0e49fbe810fcb3bb88622 (presubmit successful).
5 years, 4 months ago (2015-08-21 16:41:05 UTC) #4
Karl
5 years, 4 months ago (2015-08-21 16:41:17 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1303003002/diff/20001/tests_lit/parse_errs/ba...
File tests_lit/parse_errs/bad-switch-case.test (right):

https://codereview.chromium.org/1303003002/diff/20001/tests_lit/parse_errs/ba...
tests_lit/parse_errs/bad-switch-case.test:1: 
On 2015/08/20 21:18:03, stichnot wrote:
> Remove blank lines at beginning and end of file

Done.

Powered by Google App Engine
This is Rietveld 408576698