Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1302953002: Use macro for AudioInputBufferParameters alignment. (Closed)

Created:
5 years, 4 months ago by Henrik Grunell
Modified:
5 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@check_sequence_input_process_boundary
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use macro for AudioInputBufferParameters alignment. Also compile assert on size so that it's the same as AudioBus alignment. BUG=517871, 519336 Committed: https://crrev.com/1d3c8fa2f0e948c59ba433e2fa0f3fc145cfe3be Cr-Commit-Position: refs/heads/master@{#344584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M media/audio/audio_parameters.h View 1 chunk +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
Henrik Grunell
5 years, 4 months ago (2015-08-20 16:58:30 UTC) #2
tommi (sloooow) - chröme
lgtm :D
5 years, 4 months ago (2015-08-20 17:09:41 UTC) #3
tommi (sloooow) - chröme
On 2015/08/20 17:09:41, tommi wrote: > lgtm :D ooh, looks like the bots are blushing!
5 years, 4 months ago (2015-08-20 17:10:16 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1293503002 Patch 160001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-20 17:10:54 UTC) #7
Henrik Grunell
On 2015/08/20 17:10:16, tommi wrote: > On 2015/08/20 17:09:41, tommi wrote: > > lgtm :D ...
5 years, 4 months ago (2015-08-20 17:16:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302953002/1
5 years, 4 months ago (2015-08-20 19:27:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 21:07:02 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 21:07:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d3c8fa2f0e948c59ba433e2fa0f3fc145cfe3be
Cr-Commit-Position: refs/heads/master@{#344584}

Powered by Google App Engine
This is Rietveld 408576698