Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1302913002: Don't try to dllexport InkDropAnimationControllerStub (Closed)

Created:
5 years, 4 months ago by hans
Modified:
5 years, 4 months ago
Reviewers:
sadrul, bruthig
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to dllexport InkDropAnimationControllerStub It's in an anonymous namespace, so it cannot be exported, and this causes an error on the Win-Clang bots: ..\..\ui\views\animation\ink_drop_animation_controller_factory.cc(20,20) : error: 'views::(anonymous namespace)::InkDropAnimationControllerStub' must have external linkage when declared 'dllexport' class VIEWS_EXPORT InkDropAnimationControllerStub ^ I'm pretty sure this class was never intended to be exported. BUG=82385 TBR=bruthig,sadrul Committed: https://crrev.com/2ca3862cb26d8708d31f82ca6c91399c328afa6b Cr-Commit-Position: refs/heads/master@{#344511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/animation/ink_drop_animation_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302913002/1
5 years, 4 months ago (2015-08-20 15:04:23 UTC) #2
bruthig
On 2015/08/20 15:04:23, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 4 months ago (2015-08-20 15:17:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 16:14:46 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 16:15:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ca3862cb26d8708d31f82ca6c91399c328afa6b
Cr-Commit-Position: refs/heads/master@{#344511}

Powered by Google App Engine
This is Rietveld 408576698